FieldValue changes for transform_operation #8017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
dconeybe
approved these changes
May 3, 2021
| } else { | ||
| // coerce to empty array. | ||
| // coerce to empty array.; |
There was a problem hiding this comment.
ultranit: This semicolon addition to the end of the line appears to be a typo
| } | ||
| return FieldValue::FromArray(std::move(result)); | ||
|
|
||
| google_firestore_v1_Value result{}; |
There was a problem hiding this comment.
ultranit: Can the empty initializer list just be omitted? Its presence throws me off a bit because I'm wondering if it is there for some specific reason. Also on lines 393 and 418.
There was a problem hiding this comment.
The empty initializer zeroes-out the values. This is a struct, so there is no default constructor.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are two files from #7904 that should be able to be reviewed relatively independently. Most of the missing functions are in review here: #7991 (such as
IsArray.This PR changes all FieldTransforms to use Protobuf directly. It follows the code on Android: https://github.com/firebase/firebase-android-sdk/tree/master/firebase-firestore/src/main/java/com/google/firebase/firestore/model/mutation