-
Notifications
You must be signed in to change notification settings - Fork 4k
🐛 [firebase_dynamic_links] Crash when generating a short link or dynamic link with no internet connection on iOS #7911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@Tom3652
And if we look further down in the log, it seems to be pointing to Flutter's standard code which probably isn't handling the exception and the assertion failure seems to be coming from Flutter itself:
For this, there's an open issue in flutter repo that you can track for further updates: flutter/flutter#128764 This seems to be a framework issue rather than flutterfire plugin. Also, any scenario related to network connection doesn't belong to flutterfire. |
As the issue you are referred to is from has been inactive since 2018 is there something more that can be looked in to from the firebase_dynamic_links team, or do we just have to accept that the app crashes without a network connection for some time? It looks like there have been some similar issue fixed for "in_app_purchase" -> flutter/plugins#4138 |
Reopening based on above comment and also looking at recent comments in flutter/flutter#128764. @Tom3652 / @andaas4 / @maitycyrus would be helpful if either of you could confirm if this occurs using latest plugin version and framework version. Thanks. |
Hi @darshankawar, i confirm that this is still crashing the app :
I have wrapped my code by a connectivity check for safety using |
Bug still exists, tested with firebase_dynamic_links 4.2.5. |
Thanks for the updates. I am also seeing the same behavior and crash log using plugin's example. It crashes while trying to generate dynamic link and short link when there's no internet / wifi, but doesn't crash while generating initial link and long link. console crash log
ios simulator crash log
/cc @russellwheatley |
Is there any progress on that issue? |
Has anyone found a solution to this problem? |
as @darshankawar said, this crash is from flutter and ios error handling. but there is always sides ways. import 'package:http/http.dart' as http;
...
final DynamicLinkParameters parameters = DynamicLinkParameters(
uriPrefix: uriPrefix // your dynamic link prefix
link: link // link which you want to make shorten
)
try {
await http.get(parameters.link);
} catch (e) {
// display error or show toast
return;
}
final result = await FirebaseDynamicLinks.instance.buildShortLink(parameters) the reason why error has occur is the state of offline. or it also can be occured when dynamic link server down. hope this helpful. |
Any updates regarding this issue ? |
Any updates here?? |
I've just tested airplane mode on my iPhone and I was able to consistently build long/short dynamic links. Not sure how that is possible. Does anyone else find it does not crash anymore? |
Hi @russellwheatley , i am still having the issue with the current latest version of I just set the airplane mode (without wifi or any network connections) and call :
|
Ah, I think my iPhone was using the network via my mac, I'm now able to reproduce 👍 |
Bug report
Describe the bug
A crash happens when there is no internet connection and building a new short dynamic link on iOS.
This doesn't crash on Android but throw an error :
You will find the crash log below :
Steps to reproduce
Steps to reproduce the behavior:
FirebaseDynamicLinks.instance.buildShortLink()
Expected behavior
The application should not crash.
Flutter doctor
Click To Expand
Flutter dependencies
Run
flutter pub deps -- --style=compact
and paste the output below:Click To Expand
The text was updated successfully, but these errors were encountered: