Skip to content

fix(dynamic-links): fix crash when building dynamic link with no internet #9942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 16, 2022

Description

Codec wasn't able to parse NSUrl & NSError which was causing app to crash. I've removed them from the details object sent back to Flutter as they aren't used.

The error message has also been replaced. An unknown error has occurred for the more helpful The request timed out which is already a description in the underlying native error.

Related Issues

fixes #7911

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(dynamic-links): fix crash when building short link with no internet fix(dynamic-links): fix crash when building dynamic link with no internet Nov 16, 2022
@russellwheatley russellwheatley merged commit 1282855 into master Nov 17, 2022
@russellwheatley russellwheatley deleted the @russell/dynamic-7911 branch November 17, 2022 09:44
@firebase firebase locked and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_dynamic_links] Crash when generating a short link or dynamic link with no internet connection on iOS
3 participants