[FLPY-12] Fixed the duplicate entity check logic and allow entity reuse between RotationCylinder and UniformRefinement#1031
Merged
benflexcompute merged 2 commits intodevelopfrom May 12, 2025
Conversation
…se between RotationCylinder and UniformRefinement
angranl-flex
approved these changes
May 12, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2025
…se between RotationCylinder and UniformRefinement (#1031) * [FLPY-12] Fixed the duplicate entity check logic and allow entity reuse between RotationCylinder and UniformRefinement * Added more unit test
github-actions bot
pushed a commit
that referenced
this pull request
May 12, 2025
…se between RotationCylinder and UniformRefinement (#1031) * [FLPY-12] Fixed the duplicate entity check logic and allow entity reuse between RotationCylinder and UniformRefinement * Added more unit test
benflexcompute
added a commit
that referenced
this pull request
May 12, 2025
…llow entity reuse between RotationCylinder and UniformRefinement (#1034) * [FLPY-12] Fixed the duplicate entity check logic and allow entity reuse between RotationCylinder and UniformRefinement (#1031) * [FLPY-12] Fixed the duplicate entity check logic and allow entity reuse between RotationCylinder and UniformRefinement * Added more unit test * Fixed conflict --------- Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: Ben Yuan <ben@flexcompute.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…