This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Re-split ocmock into source set and static lib #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This re-lands flutter#399 with complete_static_lib=true in the static library target. static_library does not includes sources from its dependencies, and since this target had no (direct) sources of its own, was being built empty in the original version of this split. The complete_static_lib forces the library to include sources from its dependencies.
gaaclarke
approved these changes
Sep 11, 2020
|
Context is that this is required for flutter/engine#20531, which I don't have the context on. @justinmc I'm curious why we're unable to link against the static library directly? |
|
I was running into an error described in my comment here when I tried to do this directly. CC @gaaclarke who helped me overcome that.
|
|
For archaeologists |
|
Just confirmed that indeed |
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This re-lands flutter#399 with complete_static_lib=true in the static library target. static_library does not includes sources from its dependencies, and since this target had no (direct) sources of its own, was being built empty in the original version of this split. The complete_static_lib forces the library to include sources from its dependencies.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-lands #399 with complete_static_lib=true in the static library
target.
static_library does not includes sources from its dependencies, and
since this target had no (direct) sources of its own, was being built
empty in the original version of this split. The complete_static_lib
forces the library to include sources from its dependencies.