This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update OCMock to version 3.7.1 #21111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
ocmock-371
branch
from
c11f702 to
a65a70b
Compare
cbracken
changed the title
cbracken
force-pushed
the
ocmock-371
branch
from
a65a70b to
ef37ac9
Compare
Merged
|
Hmm looks like this is still getting the same failure in the Mac iOS Engine tests. (The other web tests failure is just a timeout). |
This gets us to latest and fixes a warning about a missing cast. This rolls buildroot to f83d1d7 Related patch: flutter/buildroot#401
cbracken
force-pushed
the
ocmock-371
branch
from
ef37ac9 to
5848beb
Compare
|
|
|
Update is that flutter/buildroot#403 re-splits these into a source_set and static_library but forcing the static_library to inherit all the sources in the dependency (which is non-standard, but supported for cases like this). That PR has landed in the buildroot -- will get it rolled to the engine once we're done dealing with the P0 flakiness issue in the iOS Scenario tests. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets us to latest and fixes a warning about a missing cast.
Related patch: flutter/buildroot#401
Related patch: flutter/buildroot#402