Wire up Opacity on Fuchsia, round 2 #12984
Conversation
|
What are the links to the following bugs?
|
There was a problem hiding this comment.
It might be nice to add some layer unit tests like flow/layers/opacity_layer_unittests.cc for the modified layers (see flow/layers/physical_shape_layer_unittests.cc for an example).
BTW, it might be nice to measure the engine size change by this PR. The device lab test hello_world_android__compile might be handy. (See https://github.com/flutter/flutter/tree/master/dev/devicelab#running-tests-against-a-local-engine-build on how to run it.)
Updated CL description |
|
Was a lot of work just to rebase on 3 weeks worth of changes. Writing tests now |
|
@arbreng is this ready for review, or are you still working on it? |
arbreng
added
affects: engine
code health
and removed
Work in progress (WIP)
| } | ||
| ClearChildren(); | ||
| Add(new_child); | ||
| void OpacityLayer::Add(std::shared_ptr<Layer> layer) { |
There was a problem hiding this comment.
can we add an FML_DCHECK to ensure that this only gets called once?
There was a problem hiding this comment.
It is perfectly legal to call this method N times though; its ContainerLayer::Add that should only be called once. I don't think I can add an FML_DCHECK to that without add a should_have_one_child() virtual, or something similar
|
@arbreng, I assume this is still being worked on? |
|
Closing this PR in favor of #14024 because I'm working out of flutter repo directly now. I fixed all of iskakaushik's and liyuqian's feedback |
[fuchsia] Wire up OpacityLayer to Scenic
Remove the opacity exposed from ChildView, as that was added mistakenly.
Make the layer stack explicit in SceneBuilder instead of implicit in Layer, and remove
parent().
On Fuchsia, add a code-path for compositing OpacityLayers using the system
compositor, which exposes a fastpath for opacity via Scenic.
This will only work under certain circumstances, in particular nested
Opacity() widgets will not render correctly!
On Fuchsia, add a code path for compositing PhysicalShapeLayers using
the system compositor, which allows cross-process shadows. Set to off by default,
which restores performant shadows on Fuchsia.
Finally, we centralize the logic for switching between the system-composited
and flutter-composited paths using SystemCompositedContainerLayer. We also
centralize the logic for computing elevation there. This allows the removal of several
OS_FUCHSIA-specific code-paths.
Test: Ran workstation on Fuchsia; ran flow_unittests; ran flutter macrobenchmarks
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/23711
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/24163