This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Wire up Opacity on Fuchsia, round 2 #14024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New, cleaner PR from #12984 |
arbreng
force-pushed
the
flow-unittests
branch
from
86b47b6 to
0dce780
Compare
chinmaygarde
approved these changes
Nov 27, 2019
arbreng
force-pushed
the
flow-unittests
branch
9 times, most recently
from
054632a to
976abbb
Compare
arbreng
force-pushed
the
expose-opacity
branch
from
80d06a6 to
319d563
Compare
arbreng
added
affects: engine
waiting for tree to go green
arbreng
force-pushed
the
flow-unittests
branch
3 times, most recently
from
8b3c264 to
d4d1206
Compare
arbreng
removed
the
waiting for tree to go green
arbreng
force-pushed
the
flow-unittests
branch
from
d4d1206 to
fd6b81b
Compare
arbreng
force-pushed
the
expose-opacity
branch
from
319d563 to
5b08659
Compare
arbreng
force-pushed
the
expose-opacity
branch
from
cd6fb83 to
ea67e5b
Compare
arbreng
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2019
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit d117ac9.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit d117ac9.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit d117ac9.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit d117ac9.
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit d117ac9.
iskakaushik
added a commit
that referenced
this pull request
Dec 18, 2019
iskakaushik
pushed a commit
to iskakaushik/engine
that referenced
this pull request
Dec 18, 2019
This reverts commit 6ea69a0. On top of the revert, it reverted a commit in the PR: flutter#14024 This reverts commit ea67e5b.
iskakaushik
added a commit
that referenced
this pull request
Dec 19, 2019
mikejurka
added a commit
to mikejurka/engine
that referenced
this pull request
Dec 19, 2019
This reverts commit d117ac9.
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
* Remove erroneous ChildView opacity * Wire frame metrics through contexts * Maintain layer stack inside of SceneBuilder * Remove EnsureSingleChild * Centralize system-composite and elevation logic * Wire up OpacityLayer to Scenic
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Mar 13, 2020
This reverts commit 6ea69a0. On top of the revert, it reverted a commit in the PR: flutter#14024 This reverts commit ea67e5b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[fuchsia] Wire up OpacityLayer to Scenic
Remove the opacity exposed from ChildView, as that was added mistakenly.
Make the layer stack explicit in SceneBuilder instead of implicit in Layer, and remove
parent().
On Fuchsia, add a code-path for compositing OpacityLayers using the system
compositor, which exposes a fastpath for opacity via Scenic.
This will only work under certain circumstances, in particular nested
Opacity() widgets will not render correctly!
On Fuchsia, add a code path for compositing PhysicalShapeLayers using
the system compositor, which allows cross-process shadows. Set to off by default,
which restores performant shadows on Fuchsia.
Finally, we centralize the logic for switching between the system-composited
and flutter-composited paths using SystemCompositedContainerLayer. We also
centralize the logic for computing elevation there. This allows the removal of several
OS_FUCHSIA-specific code-paths.
Test: Ran workstation on Fuchsia; ran flow_unittests; ran flutter macrobenchmarks
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/23711
Bug: https://bugs.fuchsia.dev/p/fuchsia/issues/list/24163