This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. #16214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds recursively from the emebdder. This was never thread safe to shutdown of the concurrent message loop.
jason-simmons
approved these changes
Jan 30, 2020
cbracken
approved these changes
Jan 30, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2020
…ve threads recursively from the emebdder. (flutter/engine#16214)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 30, 2020
…ve threads recursively from the emebdder. (flutter/engine#16214)
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 30, 2020
flutter/engine@6061b80...f6526c0 git log 6061b80..f6526c0 --first-parent --oneline 2020-01-30 [email protected] Roll src/third_party/skia 25bcd6a6215e..8f44c3504ca6 (2 commits) (flutter/engine#16243) 2020-01-30 [email protected] Roll src/third_party/skia 24ed75db12ba..25bcd6a6215e (5 commits) (flutter/engine#16234) 2020-01-30 [email protected] Make output of run_tests.py easier to understand. (flutter/engine#16229) 2020-01-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from c3sk5... to MK0YU... (flutter/engine#16221) 2020-01-30 [email protected] Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. (flutter/engine#16214) 2020-01-30 [email protected] Correct the Fuchsia licenses golden file (flutter/engine#16215) 2020-01-30 [email protected] Roll src/third_party/skia a2a0c8a2c475..24ed75db12ba (12 commits) (flutter/engine#16216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
stuartmorgan-g
pushed a commit
to stuartmorgan-g/engine
that referenced
this pull request
Jan 30, 2020
…ds recursively from the emebdder. (flutter#16214) This was never thread safe to shutdown of the concurrent message loop.
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ds recursively from the emebdder. (flutter#16214) This was never thread safe to shutdown of the concurrent message loop.
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ve threads recursively from the emebdder. (flutter#16214)" This reverts commit b9bfc2f.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was never thread-safe to shutdown of the concurrent message loop. There is no saving this test. I tried to do it with mutexes in static variables but was righteously punished. Will setup a harness for testing stuff like this separately.
xref flutter/flutter#49745