Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Make output of run_tests.py easier to understand. #16229

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Make output of run_tests.py easier to understand. #16229

merged 1 commit into from
Jan 30, 2020

Conversation

chinmaygarde
Copy link
Member

  • The outputs of all commands are not printed and not just commands that fail.
  • The stdout and stderr are now printed in order.
  • Clear dividers mark logs from specific subprocesses or errors.
  • The test whose run failed should now be exactly on top of the error message and code.

@chinmaygarde
Make output of run_tests.py easier to understand.
90d3274 
* The outputs of all commands are not printed and not just commands that fail.
* The stdout and stderr are now printed in order.
* Clear dividers mark logs from specific subprocesses or errors.
* The test whose run failed should now be exactly on top of the error message and code.
@auto-assign auto-assign bot requested a review from liyuqian January 30, 2020 04:00
@chinmaygarde
Copy link
Member Author

Inspired by this failed run. The python stack trace is printed before the output form the subprocess that caused that crash. The stderr/stdout results are not correctly interleaved. Its impossible to tell which test was responsible for the failure.

liyuqian
liyuqian approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chinmaygarde chinmaygarde merged commit fc1936f into flutter:master Jan 30, 2020
@chinmaygarde chinmaygarde deleted the better_logs branch January 30, 2020 04:47
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2020
@engine-flutter-autoroll
fc1936f Make output of run_tests.py easier to understand. (flutter/en…
ad310b7 
…gine#16229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2020
@engine-flutter-autoroll
fc1936f Make output of run_tests.py easier to understand. (flutter/en…
c3ce956 
…gine#16229)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2020
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Jan 30, 2020
@engine-flutter-autoroll
Roll engine 6061b80..f6526c0 (7 commits) (#49799)
4673724 
flutter/engine@6061b80...f6526c0

git log 6061b80..f6526c0 --first-parent --oneline
2020-01-30 [email protected] Roll src/third_party/skia 25bcd6a6215e..8f44c3504ca6 (2 commits) (flutter/engine#16243)
2020-01-30 [email protected] Roll src/third_party/skia 24ed75db12ba..25bcd6a6215e (5 commits) (flutter/engine#16234)
2020-01-30 [email protected] Make output of run_tests.py easier to understand. (flutter/engine#16229)
2020-01-30 [email protected] Roll fuchsia/sdk/core/mac-amd64 from c3sk5... to MK0YU... (flutter/engine#16221)
2020-01-30 [email protected] Remove buggy test to check if tasks can be posted on all native threads recursively from the emebdder. (flutter/engine#16214)
2020-01-30 [email protected] Correct the Fuchsia licenses golden file (flutter/engine#16215)
2020-01-30 [email protected] Roll src/third_party/skia a2a0c8a2c475..24ed75db12ba (12 commits) (flutter/engine#16216)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
stuartmorgan-g pushed a commit to stuartmorgan-g/engine that referenced this pull request Jan 30, 2020
@chinmaygarde @stuartmorgan-g
Make output of run_tests.py easier to understand. (flutter#16229)
a06283d 
* The outputs of all commands are not printed and not just commands that fail.
* The stdout and stderr are now printed in order.
* Clear dividers mark logs from specific subprocesses or errors.
* The test whose run failed should now be exactly on top of the error message and code.
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@chinmaygarde @NoamDev
Make output of run_tests.py easier to understand. (flutter#16229)
019473b 
* The outputs of all commands are not printed and not just commands that fail.
* The stdout and stderr are now printed in order.
* Clear dividers mark logs from specific subprocesses or errors.
* The test whose run failed should now be exactly on top of the error message and code.
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "Make output of run_tests.py easier to understand. (flutter#16229
9455a20 
)"

This reverts commit 019473b.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liyuqian liyuqian liyuqian approved these changes

@cbracken cbracken Awaiting requested review from cbracken

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chinmaygarde @liyuqian @googlebot