Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

remove FrameTiming named constructor #20380

Merged
merged 1 commit into from
Aug 10, 2020
Merged

remove FrameTiming named constructor #20380

merged 1 commit into from
Aug 10, 2020

Conversation

CareF
Copy link
Contributor

@CareF CareF commented Aug 10, 2020

Description

This is the follow up of #20229 to remove the duplicate for sync the change in flutter/flutter.

Related Issues

flutter/flutter#62689

Tests

N/A

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@CareF CareF requested a review from liyuqian August 10, 2020 18:17
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CareF CareF added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Aug 10, 2020
@auto-assign auto-assign bot requested a review from jason-simmons August 10, 2020 18:20
@fluttergithubbot fluttergithubbot merged commit 8b72bbc into flutter:master Aug 10, 2020
@CareF CareF deleted the remove_frame_timing_named_constructor branch August 10, 2020 19:23
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants