[web] Fix scroll wheel line delta on Firefox. #21928

ferhatb · 2020-10-16T21:34:26Z

Description

Fixed scroll wheel line delta.

Related Issues

flutter/flutter#67972

Tests

I added the following tests:

scroll_wheel integration.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [contributor guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [C++, Objective-C, Java style guides] for the engine.
I read the [tree hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

nturgut

I'll take a look at the mouse dispatch problem and let you know. Thanks for sending the PR.

mdebbar

The change in pointer_binding.dart lgtm, modulo removing the probe.

mdebbar · 2020-10-18T08:02:33Z

lib/web_ui/lib/src/engine/pointer_binding.dart

+    probe.style
+        ..fontSize = 'initial'
+        ..display = 'none';
+    html.document.body!.append(probe);


Remove the probe before returning from this function?

nturgut

I'm working on the e2e fix right now! Thanks for testing scrolling 👍

nturgut · 2020-10-19T18:25:54Z

e2etests/web/regular_integration_tests/lib/scroll_wheel_main.dart

+  _MyHomePageState createState() => _MyHomePageState();
+}
+
+class _MyHomePageState extends State<MyHomePage> {


Since you are taking a screenshot you might want to load a font as we did for test: https://github.com/flutter/engine/blob/master/e2etests/web/regular_integration_tests/lib/text_editing_main.dart#L14

We observed that the default font might change depending on the machine. (Thanks @mdebbar for the initial suggestion :) )

…#21928)

* 53d5d68 Add dart-lang/sdk's new package:clock dependency (flutter/engine#22142) * c32e3d8 Roll Skia from 7737a5bd2510 to 5567a6091ceb (8 revisions) (flutter/engine#22146) * 376045c Roll Fuchsia Linux SDK from XYN02FThN... to UKgKCjxSA... (flutter/engine#22147) * 03395de Roll Fuchsia Mac SDK from GKPwGj1Ux... to xHjtLQPQ5... (flutter/engine#22151) * 0c7e952 Manual Dart SDK roll 6e015bd9cddb to 9c6e76468ca4 (6 revisions (flutter/engine#22153) * e5f168a Update constraint to latest integration test (flutter/engine#22169) * e61e8c2 Smooth window resizing on macOS (flutter/engine#21525) * acece00 Allow parse_and_send to use access tokens (flutter/engine#22019) * 0270632 Includes roles for links, checkboxes, and radio buttons in semantics (flutter/engine#22061) * 632354d Roll Fuchsia Linux SDK from UKgKCjxSA... to PY5hNI-wY... (flutter/engine#22175) * 62d50af Add plumbing for command line arguments on Windows (flutter/engine#22094) * 06b0910 Fix possible use of std::moved value in Rasterizer (flutter/engine#22125) * 005dec4 [web] Clean up unused previousStyle logic (flutter/engine#22150) * ca05bdc Roll Skia from 5567a6091ceb to f548a028ce70 (7 revisions) (flutter/engine#22155) * 5b07ac4 Roll Fuchsia Mac SDK from xHjtLQPQ5... to ICK_JlnKJ... (flutter/engine#22188) * d615a97 Roll Fuchsia Linux SDK from PY5hNI-wY... to Usec4YBzR... (flutter/engine#22197) * 11ed711 Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157) * 07c780b [web] Assign default natural width/height for svgs that report 0,0 on firefox and ie11 (flutter/engine#22184) * b54bb88 Migrate runZoned to runZonedGuarded (flutter/engine#22198) * 247139a [web] Fix transform not invalidating path bounds causing debugValidate failure (flutter/engine#22172) * e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine#21928) * d6627c6 Reland [ios] Refactor IOSSurface factory and unify surface creation (flutter/engine#22016) * ce1dd11 Standardize macro names for dartdoc macros (flutter/engine#22180) * f81bc37 [profiling] Handle thread_info to account for killed threads (flutter/engine#22170) * fd94c86 Fix for firefox custom clipping (flutter/engine#22182) * 9ccf9f1 bring back build_test to ensure we validate licenses (flutter/engine#22201) * 38f6665 Set strut font to Roboto if the given font hasn't been registered (flutter/engine#22129) * caf32d5 Add a proc table version of embedder API (flutter/engine#21813) * ed0f477 Use preTranslate when applying offset to matrix (flutter/engine#21648) * b457e2d Refactor make_mock_engine into fl_test (flutter/engine#21585) * 28497c8 Fix typos in FlValue docs (flutter/engine#21875) * bb32446 Fix FlTextInputPlugin tear down (flutter/engine#22007) * 7a7804b Add "input shield" to capture pointer input for reinjection (flutter/engine#22067) * fe85f94 Update painting.dart (flutter/engine#22195) * 99cc50d [ios] Surface factory holds the canonical reference to the external view embedder (flutter/engine#22206)

…#21928)

ferhatb added 2 commits October 16, 2020 12:23

Compute wheel line scroll distance

792706d

Fix Firefox wheel scroll delta

b7903b4

ferhatb requested a review from nturgut October 16, 2020 21:34

google-cla bot added the cla: yes label Oct 16, 2020

googlebot added the cla: yes label Oct 16, 2020

ferhatb changed the title ~~WIP Fix scroll wheel line delta on Firefox.~~ [web] Fix scroll wheel line delta on Firefox. Oct 16, 2020

nturgut reviewed Oct 16, 2020

View reviewed changes

Remove ! check

29f08e0

ferhatb requested a review from mdebbar October 16, 2020 22:53

Merge remote-tracking branch 'upstream/master' into scrollwheel

34b37b4

mdebbar approved these changes Oct 18, 2020

View reviewed changes

This was referenced Oct 19, 2020

[integration_test][web] TestBindingEventSource is not set correctly during integration tests flutter/flutter#68502

Open

fix pointer events by setting TestBindingEventSource flutter/plugins#3168

Closed

nturgut reviewed Oct 19, 2020

View reviewed changes

chinmaygarde added the platform-web Code specifically for the web engine label Oct 22, 2020

ferhatb added 2 commits October 29, 2020 09:48

address reviewer comments. disable screenshot until infra issue is fixed

dace332

Merge remote-tracking branch 'upstream/master' into scrollwheel

0e53c56

ferhatb merged commit e4dffc1 into flutter:master Oct 29, 2020

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to e4dffc107032 (21 revisions) flutter/flutter#69331

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

75de07f

…#21928)

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to 9ccf9f120ddc (26 revisions) flutter/flutter#69335

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

462cd3a

…#21928)

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to fe85f946db04 (34 revisions) flutter/flutter#69343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

f3f78ed

…#21928)

GaryQian mentioned this pull request Oct 29, 2020

Roll engine from 073263e39d1d to fe85f946db04 (34 revisions) manual flutter/flutter#69347

Closed

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to fe85f946db04 (34 revisions) flutter/flutter#69349

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

7f9abd9

…#21928)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 073263e39d1d to 99cc50dfffab (35 revisions) flutter/flutter#69353

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

23c490c

…#21928)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 073263e39d1d to 7d6180c3014a (37 revisions) flutter/flutter#69357

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

f9a1145

…#21928)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 99cc50dfffab1 to 7d6180c3014a (2 revisions) flutter/flutter#69365

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine…

8abd0e8

…#21928)

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020

[web] Fix scroll wheel line delta on Firefox. (flutter#21928)

e1985ed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[web] Fix scroll wheel line delta on Firefox. #21928

[web] Fix scroll wheel line delta on Firefox. #21928

Uh oh!

ferhatb commented Oct 16, 2020

Uh oh!

nturgut left a comment

Uh oh!

mdebbar left a comment

Uh oh!

mdebbar Oct 18, 2020

Uh oh!

ferhatb Oct 29, 2020

Uh oh!

nturgut left a comment

Uh oh!

nturgut Oct 19, 2020

Uh oh!

ferhatb Oct 29, 2020

Uh oh!

Uh oh!

[web] Fix scroll wheel line delta on Firefox. #21928

[web] Fix scroll wheel line delta on Firefox. #21928

Uh oh!

Conversation

ferhatb commented Oct 16, 2020

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

Uh oh!

nturgut left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar left a comment

Choose a reason for hiding this comment

Uh oh!

mdebbar Oct 18, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

nturgut left a comment

Choose a reason for hiding this comment

Uh oh!

nturgut Oct 19, 2020

Choose a reason for hiding this comment

Uh oh!

ferhatb Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!