Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix for firefox custom clipping #22182

Merged
merged 2 commits into from
Oct 29, 2020
Merged

[web] Fix for firefox custom clipping #22182

merged 2 commits into from
Oct 29, 2020

Conversation

ferhatb
Copy link
Contributor

@ferhatb ferhatb commented Oct 29, 2020 •
edited
Loading

Description

Fixes bug due to Firefox handling of clipPathUnits="objectBoundingBox". Unlike other browsers using 1x1 units for the path that map to target element, it seems to be effected by transform stack. Switched to using target units instead.

Related Issues

flutter/flutter#58397
flutter/flutter#57801
flutter/flutter#50508

Tests

Covered by compositing_golden_test.dart pushPhysicalShape that uses roundrect as clip path, but unit test screenshots for firefox not available.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the [contributor guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [C++, Objective-C, Java style guides] for the engine.
  • I read the [tree hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

  • I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

@ferhatb ferhatb requested a review from yjbanov October 29, 2020 00:25
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla bot added the cla: yes label Oct 29, 2020
@ferhatb ferhatb added waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. platform-web Code specifically for the web engine labels Oct 29, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2020
@ferhatb ferhatb added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 29, 2020
@fluttergithubbot fluttergithubbot merged commit fd94c86 into flutter:master Oct 29, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
3f24ee6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
c6f770d
@GaryQian GaryQian mentioned this pull request Oct 29, 2020
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 29, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
5ae404c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
7865287
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
ea7765c
GaryQian pushed a commit to flutter/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
Roll Engine from 073263e to 99cc50d (35 revisions) (#69353)
e444b1e 
* 53d5d68 Add dart-lang/sdk's new package:clock dependency (flutter/engine#22142)

* c32e3d8 Roll Skia from 7737a5bd2510 to 5567a6091ceb (8 revisions) (flutter/engine#22146)

* 376045c Roll Fuchsia Linux SDK from XYN02FThN... to UKgKCjxSA... (flutter/engine#22147)

* 03395de Roll Fuchsia Mac SDK from GKPwGj1Ux... to xHjtLQPQ5... (flutter/engine#22151)

* 0c7e952 Manual Dart SDK roll 6e015bd9cddb to 9c6e76468ca4 (6 revisions (flutter/engine#22153)

* e5f168a Update constraint to latest integration test (flutter/engine#22169)

* e61e8c2 Smooth window resizing on macOS (flutter/engine#21525)

* acece00 Allow parse_and_send to use access tokens (flutter/engine#22019)

* 0270632 Includes roles for links, checkboxes, and radio buttons in semantics (flutter/engine#22061)

* 632354d Roll Fuchsia Linux SDK from UKgKCjxSA... to PY5hNI-wY... (flutter/engine#22175)

* 62d50af Add plumbing for command line arguments on Windows (flutter/engine#22094)

* 06b0910 Fix possible use of std::moved value in Rasterizer (flutter/engine#22125)

* 005dec4 [web] Clean up unused previousStyle logic (flutter/engine#22150)

* ca05bdc Roll Skia from 5567a6091ceb to f548a028ce70 (7 revisions) (flutter/engine#22155)

* 5b07ac4 Roll Fuchsia Mac SDK from xHjtLQPQ5... to ICK_JlnKJ... (flutter/engine#22188)

* d615a97 Roll Fuchsia Linux SDK from PY5hNI-wY... to Usec4YBzR... (flutter/engine#22197)

* 11ed711 Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157)

* 07c780b [web] Assign default natural width/height for svgs that report 0,0 on firefox and ie11 (flutter/engine#22184)

* b54bb88 Migrate runZoned to runZonedGuarded (flutter/engine#22198)

* 247139a [web] Fix transform not invalidating path bounds causing debugValidate failure (flutter/engine#22172)

* e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine#21928)

* d6627c6 Reland [ios] Refactor IOSSurface factory and unify surface creation (flutter/engine#22016)

* ce1dd11 Standardize macro names for dartdoc macros (flutter/engine#22180)

* f81bc37 [profiling] Handle thread_info to account for killed threads (flutter/engine#22170)

* fd94c86 Fix for firefox custom clipping (flutter/engine#22182)

* 9ccf9f1 bring back build_test to ensure we validate licenses (flutter/engine#22201)

* 38f6665 Set strut font to Roboto if the given font hasn't been registered (flutter/engine#22129)

* caf32d5 Add a proc table version of embedder API (flutter/engine#21813)

* ed0f477 Use preTranslate when applying offset to matrix (flutter/engine#21648)

* b457e2d Refactor make_mock_engine into fl_test (flutter/engine#21585)

* 28497c8 Fix typos in FlValue docs (flutter/engine#21875)

* bb32446 Fix FlTextInputPlugin tear down (flutter/engine#22007)

* 7a7804b Add "input shield" to capture pointer input for reinjection (flutter/engine#22067)

* fe85f94 Update painting.dart (flutter/engine#22195)

* 99cc50d [ios] Surface factory holds the canonical reference to the external view embedder (flutter/engine#22206)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020
@engine-flutter-autoroll
fd94c86 Fix for firefox custom clipping (flutter/engine#22182)
1e98775
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
@ferhatb @chaselatta
Fix for firefox custom clipping (flutter#22182)
8427bc5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yjbanov yjbanov yjbanov approved these changes

Assignees
No one assigned
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ferhatb @fluttergithubbot @yjbanov