This repository was archived by the owner on Feb 25, 2025. It is now read-only.
More reverts for insecure http policy since the Dart implementation is reverted #25623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Apr 16, 2021
|
Can we rebase this to make the presubmits pass and land this please? |
|
No sure the presubmit failures are flakes. |
|
Ya, I think something's properly broken. It didn't reproduce locally. I'll still have to dig in a bit when I got some time. |
|
Added the WIP tag in the meantime. |
9 tasks
|
Before this lands make sure it doesn't regress flutter/flutter#77132 again. It was easy to test locally with the Info.plist change reported in the issue. |
|
Since this has apparently been abandoned I'm going to close it; please let me know if we need to track something. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting due to flutter/flutter#72723.
Need to be re-implemented at some point for flutter/flutter#54448.
Reverting this part because it uses APIs (via vm-entrypoint) to be reverted in https://dart-review.googlesource.com/c/sdk/+/195485. Removed an additional read against the Android SDK because it would be slow and doesn't feed into anything anymore.