Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Remove unused parameter in flutter application info loader #25940

Merged
merged 1 commit into from
May 10, 2021

Conversation

creativepsyco
Copy link
Contributor

@creativepsyco creativepsyco commented May 5, 2021

Internal issue: b/187271871

This PR is mostly a cleaner revert of #25299 After that PR was submitted there is still a call

NetworkSecurityPolicy.getInstance().isCleartextTrafficPermitted()

inside ApplicationInfoLoader.java which results in calling the underlying xml parsing via the NetworkSecurityPolicy. This results in additional I/O contention in the main thread.

Since #25299 is anyways currently turned off as a feature --disallow-insecure-connections, maybe this can be reverted as well until we can get some other way of passing this info across.

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

  • Updated the tests

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label May 5, 2021
@creativepsyco creativepsyco force-pushed the remove_unused_param branch from 847b19d to 3bca000 Compare May 5, 2021 10:05
@creativepsyco creativepsyco changed the title Remove unused parameter. Remove unused parameter in flutter application info loader May 5, 2021
@creativepsyco creativepsyco marked this pull request as ready for review May 5, 2021 11:09
@creativepsyco
Copy link
Contributor Author

@xster please take a look thanks!

@zanderso zanderso requested a review from jason-simmons May 5, 2021 17:03
@xster
Copy link
Member

xster commented May 7, 2021

Rerunning CI. I was trying something similar in #25623 but was running into some actual CI breakages. But it looks like your PR will pass.

@creativepsyco
Copy link
Contributor Author

Lets merge this first then. or should I revert this

@xster
Copy link
Member

xster commented May 9, 2021

Let's merge yours. We've been having CI issues last week. If the rerun still doesn't work, you might have to rebase.

@xster xster added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 9, 2021
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Android AOT Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows UWP Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 9, 2021
@creativepsyco creativepsyco force-pushed the remove_unused_param branch from 3bca000 to 7f943ba Compare May 9, 2021 08:35
@creativepsyco
Copy link
Contributor Author

creativepsyco commented May 9, 2021 via email

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants