This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Remove unused parameter in flutter application info loader #25940
Merged
fluttergithubbot
merged 1 commit into
flutter:master
from
creativepsyco:remove_unused_param
May 10, 2021
Merged
Remove unused parameter in flutter application info loader #25940
fluttergithubbot
merged 1 commit into
flutter:master
from
creativepsyco:remove_unused_param
May 10, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
847b19d
to
3bca000
Compare
@xster please take a look thanks! |
jason-simmons
approved these changes
May 5, 2021
Rerunning CI. I was trying something similar in #25623 but was running into some actual CI breakages. But it looks like your PR will pass. |
Lets merge this first then. or should I revert this |
Let's merge yours. We've been having CI issues last week. If the rerun still doesn't work, you might have to rebase. |
This pull request is not suitable for automatic merging in its current state.
|
3bca000
to
7f943ba
Compare
Rebased.
… |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 10, 2021
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
cla: yes
platform-android
waiting for tree to go green
This PR is approved and tested, but waiting for the tree to be green to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal issue: b/187271871
This PR is mostly a cleaner revert of #25299 After that PR was submitted there is still a call
inside
ApplicationInfoLoader.java
which results in calling the underlying xml parsing via the NetworkSecurityPolicy. This results in additional I/O contention in the main thread.Since #25299 is anyways currently turned off as a feature
--disallow-insecure-connections
, maybe this can be reverted as well until we can get some other way of passing this info across.If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.