Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Improve platform views performance" #31468

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

blasten
Copy link

@blasten blasten commented Feb 15, 2022

The issue is in the test code itself.

Test fix PR: flutter/flutter#98479
Reverts #31431

Copy link
Member

@zanderso zanderso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rslgtm

@blasten blasten added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 15, 2022
@fluttergithubbot fluttergithubbot merged commit 5f0271a into main Feb 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 15, 2022
@zanderso zanderso deleted the revert-31431-revert-31198-pv branch February 16, 2022 02:45
@zanderso
Copy link
Member

Some good results from SkiaPerf: https://flutter-flutter-perf.skia.org/e/?begin=1644939237&end=1644977719&keys=X93c52a2e0c9092afa59569a3e9af0667&num_commits=50&request_type=1&xbaroffset=27594

@blasten
Copy link
Author

blasten commented Feb 17, 2022

awesome!

@eggfly
Copy link
Member

eggfly commented May 10, 2022

There was a QR code or camera scene that using old HybridComposition in our project, which is using SurfaceView or TextureView, then the lockHardwareCanvas and do super.draw(hardwareCanvas) will not work.
Both Camera and WebView are using platform view in our app, but they will never show at a same time. So can I use the initExpensiveAndroidView to show the camera surface and use the new initAndroidView to show webview?

Besides some BaiduMap sdk or other MapView, if they are using draw ops into canvas they will work, nor if they are using surface or texture, may also not work?
@blasten Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants