Handle SurfaceView in a VirtualDisplay #33599
Conversation
|
Is this Linux checked being worked on? Seems like a lot of people are waiting on this fix. |
|
I have followed most of the related links to this pull request. Is there anything we can do to help get this completed? |
|
@penhorwood I was waiting for #33574 to land. This fix needs an integration test, so this issue doesn't reoccur in the future. |
|
Any progress on releasing this fix? |
|
Seems we all lost another week to this issue. Are we still waiting on a integration test? |
|
Any news on this? Our team has been blocked for kicking a new release of our product for weeks 🙃 |
|
@blasten - Any chance this will get completed soon? |
blasten
force-pushed
the
tx_rework
branch
4 times, most recently
from
49f51ab to
3401c16
Compare
|
Getting closer. I like the changes you made to the patch. What happens next? |
|
Gold has detected about 1 new digest(s) on patchset 14. |
blasten
force-pushed
the
tx_rework
branch
4 times, most recently
from
38dad8f to
cca28ef
Compare
|
Gold has detected about 21 new digest(s) on patchset 18. |
|
Anyone can tell me about plan to merge this PR? |
|
Gold has detected about 25 new digest(s) on patchset 22. |
|
Gold has detected about 25 new digest(s) on patchset 23. |
|
Gold has detected about 1 new digest(s) on patchset 24. |
|
Gold has detected about 22 new digest(s) on patchset 25. |
blasten
changed the title
blasten
added
the
waiting for tree to go green
This reverts commit e986f43.
Fixes flutter/flutter#103630
Fixes flutter/flutter#105882
SurfaceViews punch a whole in the window to allow the surface to be displayed.
#31468 caused an issue where platform views that embed a SurfaceView cannot be composed correctly in Flutter. This used to work previously thanks to VirtualDisplay although it wasn't a documented behavior.
This PR brings back the VirtualDisplay for views that can do their own drawing without the Android view. For example, a plugin like flutter-mapbox-gl uses SurfaceView to issue GL commands to this surface directly.
To review this PR, you would need to compare the differences between this patch and https://github.com/flutter/engine/pull/31468/files.