Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Do not update virtual display size #34414

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

cyanglaz
Copy link
Contributor

This reverts part of #33599

#33599 added a logic in virtual display to resize if it is larger than the physical screen of the device. This is implemented to avoid a crash where virtual display is requested larger than the screen, see: flutter/flutter#93115
It creates a mismatch between the size of the flutter widget and the size of the virtual display and also breaks some tests: flutter/flutter#106750

We should revert this and reinvestigate a better fix for flutter/flutter#93115

Fixes: flutter/flutter#106750

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, can we add a test and a TODO linked to a bug filed about making this better?

@cyanglaz cyanglaz marked this pull request as ready for review July 6, 2022 16:19
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Jul 6, 2022

This is good, can we add a test and a TODO linked to a bug filed about making this better?

Good call! Added a comment to explain the issue and linked the original crash issue.

Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It would be nice if we had a test in the engine that could catch this, but it is tested upstream.

@cyanglaz cyanglaz added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 6, 2022
@auto-submit auto-submit bot merged commit 493d2df into flutter:main Jul 6, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Google maps plugin on Android fails to center initial location when surface size is changed.
2 participants