This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Skip test that crashes platform #34675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
commented
Jul 14, 2022
| @Test | ||
| public void testPlatformViewLargerThanDisplaySize() throws Exception { | ||
| // Regression test for https://github.com/flutter/flutter/issues/2897. | ||
| // Regression test for https://github.com/flutter/flutter/issues/28978. |
There was a problem hiding this comment.
drive by - the issue number was wrong here, fixing it.
zanderso
approved these changes
Jul 14, 2022
dnfield
added
the
autosubmit
|
auto-submit
bot
removed
the
autosubmit
dnfield
added
the
autosubmit
|
Gold has detected about 8 new digest(s) on patchset 2. |
cyanglaz
approved these changes
Jul 14, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 14, 2022
betrevisan
pushed a commit
to betrevisan/engine
that referenced
this pull request
Jul 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#107667
Skips test that intentionally creates a vastly oversized platform view using the Virtual Display backend, which causes a crash.
This test was made flaky by #34414
We can't safely run it until the underlying issue is fixed - the suggestion I gave @blasten turned out to cause unintended regressions.