Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Skip test that crashes platform #34675

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Skip test that crashes platform #34675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7da973b
Skip test that crashes platform
dnfield Jul 14, 2022
ff9d972
Skip test that crashes platform
dnfield Jul 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...d/app/src/androidTest/java/dev/flutter/scenariosui/PlatformViewWithSurfaceViewUiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
import androidx.test.runner.AndroidJUnit4;
import dev.flutter.scenarios.PlatformViewsActivity;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
Expand Down Expand Up @@ -124,9 +125,12 @@ public void testPlatformViewWithoutOverlayIntersection() throws Exception {
goldName("testPlatformViewWithoutOverlayIntersection"));
}

// TODO(dnfield): This is not safe until https://github.com/flutter/flutter/issues/31990
// is resolved.
@Ignore("not safe until https://github.com/flutter/flutter/issues/31990 is resolved")
@Test
public void testPlatformViewLargerThanDisplaySize() throws Exception {
// Regression test for https://github.com/flutter/flutter/issues/2897.
// Regression test for https://github.com/flutter/flutter/issues/28978.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drive by - the issue number was wrong here, fixing it.

intent.putExtra("scenario_name", "platform_view_larger_than_display_size");
ScreenshotUtil.capture(
activityRule.launchActivity(intent), goldName("testPlatformViewLargerThanDisplaySize"));
Expand Down
2 changes: 1 addition & 1 deletion testing/scenario_app/lib/src/platform_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class PlatformViewNoOverlayIntersectionScenario extends Scenario

/// A platform view that is larger than the display size.
/// This is only applicable on Android while using virtual displays.
/// Related issue: https://github.com/flutter/flutter/issues/2897.
/// Related issue: https://github.com/flutter/flutter/issues/28978.
class PlatformViewLargerThanDisplaySize extends Scenario
with _BasePlatformViewScenarioMixin {
/// Creates the PlatformView scenario.
Expand Down