This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] fix and test light vs. dark theme detection #32618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robert-ancell and @cbracken, this is a spin-off of #32456 that I had trouble adding tests for. I have done some refactoring around P.S. I have included it all here for now for feedback but if you think the changes look good in principle, I can start splitting this into smaller PRs. |
|
These changes would also lay the foundations for implementing accessibility features for Linux, to make Flutter respect the high-contrast and disabled animations accessibility settings in GNOME. |
|
Changes make sense to me - let's split into smaller PRs. |
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Apr 13, 2022
This follows the common naming convention for fake implementations, and makes room for a GMock-based mock implementation that registers calls and allows settings expectations. Split off from flutter#32618.
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Apr 13, 2022
This follows the common naming convention for fake implementations, and makes room for a GMock-based mock implementation that registers calls and allows settings expectations. This is a preparation step split off from flutter#32618 that will eventually fix flutter/flutter#101438.
This was referenced Apr 13, 2022
|
I started splitting off some changes but I didn't realize the bot would get mad at me for not including tests when adding code to testing/. |
Some users have reported that toggling between light and dark system theme results in Flutter detecting the opposite theme. This is because the window text color, which is used to calculate the brightness, may not have been yet refreshed when the theme change signal is emitted. This commit replaces the unreliable (and untestable) window text color -based theme detection with the simpler alternative proposed in flutter#25535 to check for a "-dark" suffix in the theme name, which is used by convention in dark GTK theme names (Yaru vs. Yaru-dark, Adwaita vs. Adwaita-dark, Pop vs. Pop-dark, ...). Ref: flutter/flutter#101438
|
I've rebased the remaining commits and left out the GNOME 42 color-scheme changes from this. Let's fix and test the "legacy" theme detection first. |
FlSettings is an interface that provides desktop settings and notifies changes, whereas FlSettingsPlugin merely communicates the settings to the framework. This makes it straightforward to test both separately. As a bonus, it will be easy to add FlSettings implementations for other DEs too.
cbracken
approved these changes
Apr 26, 2022
cbracken
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 26, 2022
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Jun 14, 2022
Let MockBinaryMessenger internally manage the FlBinaryMessenger wrapper instance and provide it via operator FlBinaryMessenger*() to avoid having to create two objects in every test. The same technique was used for MockSettings in flutter#32618.
8 tasks
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Jun 14, 2022
Let MockBinaryMessenger internally manage the FlBinaryMessenger wrapper instance and provide it via operator FlBinaryMessenger*() to avoid having to create two objects in every test. The same technique was used for MockSettings in flutter#32618.
jpnurmi
added a commit
to jpnurmi/engine
that referenced
this pull request
Jun 14, 2022
Let MockBinaryMessenger internally manage the FlBinaryMessenger wrapper instance and provide it via operator FlBinaryMessenger*() to avoid having to create two objects in every test. The same technique was used for MockSettings in flutter#32618.
robert-ancell
pushed a commit
that referenced
this pull request
Jun 20, 2022
Let MockBinaryMessenger internally manage the FlBinaryMessenger wrapper instance and provide it via operator FlBinaryMessenger*() to avoid having to create two objects in every test. The same technique was used for MockSettings in #32618.
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…ter#34029) Let MockBinaryMessenger internally manage the FlBinaryMessenger wrapper instance and provide it via operator FlBinaryMessenger*() to avoid having to create two objects in every test. The same technique was used for MockSettings in flutter#32618.
bryan-hoang
added a commit
to bryan-hoang/dotfiles
that referenced
this pull request
Jan 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the unreliable (and untestable) window text color
-based theme detection with the simpler alternative proposed in
#25535 to check for a "-dark" suffix in the theme name,
which is used by convention in dark GTK theme names (Yaru vs. Yaru-dark,
Adwaita vs. Adwaita-dark, Pop vs. Pop-dark, ...).
Partial fix to: flutter/flutter#101438
Pre-launch Checklist
///).Before
Personally, I was able to reproduce the issue in a Pop!_OS 20.04 VM
popos-before.mp4
After
Same VM with the fix applied
popos-after.mp4