Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Linux] fix theme updates on GNOME 42 #32456

Closed
wants to merge 1 commit into from

Conversation

jpnurmi
Copy link
Member

@jpnurmi jpnurmi commented Apr 6, 2022

Prefer org.gnome.desktop.interface.color-scheme for determining the
UI color scheme. The new setting is available in GNOME 42 and later.

https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/

Fixes: flutter/flutter#101438

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jpnurmi
Copy link
Member Author

jpnurmi commented Apr 6, 2022

theme.mp4

Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the reference issue LGTM

@jpnurmi jpnurmi closed this Apr 13, 2022
@jpnurmi jpnurmi reopened this Apr 19, 2022
@jpnurmi jpnurmi changed the title [linux] fix theme updates on gnome 42 [Linux] fix theme updates on GNOME 42 Apr 19, 2022
@jpnurmi
Copy link
Member Author

jpnurmi commented Apr 19, 2022

Depends on #32618

@jpnurmi jpnurmi marked this pull request as draft April 27, 2022 07:36
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@jpnurmi
Copy link
Member Author

jpnurmi commented Apr 27, 2022

(rebase only)

Prefer `org.gnome.desktop.interface.color-scheme` for determining the
UI color scheme. The new setting is available in GNOME 42 and later.

https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/

Fixes: flutter/flutter#101438
@jpnurmi
Copy link
Member Author

jpnurmi commented May 4, 2022

Superseded by a more generic XDG desktop portal based implementation:

@jpnurmi jpnurmi closed this May 5, 2022
@jpnurmi jpnurmi deleted the color-scheme branch June 28, 2022 08:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] system theme changes not followed on gnome 42
3 participants