-
Notifications
You must be signed in to change notification settings - Fork 6k
[Linux] fix theme updates on GNOME 42 #32456
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
theme.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the reference issue LGTM
Depends on #32618 |
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
(rebase only) |
Prefer `org.gnome.desktop.interface.color-scheme` for determining the UI color scheme. The new setting is available in GNOME 42 and later. https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/ Fixes: flutter/flutter#101438
Superseded by a more generic XDG desktop portal based implementation: |
Prefer
org.gnome.desktop.interface.color-scheme
for determining theUI color scheme. The new setting is available in GNOME 42 and later.
https://blogs.gnome.org/alexm/2021/10/04/dark-style-preference/
Fixes: flutter/flutter#101438
Pre-launch Checklist
///
).