This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Linux] read settings from XDG desktop portal if available #33100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GNOME 42 (Ubuntu 22.04)
KDE (Kubuntu 22.04)
GNOME 3.36.8 (Pop!_OS 20.04)
|
8 tasks
robert-ancell
suggested changes
May 4, 2022
8 tasks
|
Can we land this? |
chinmaygarde
approved these changes
May 12, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 12, 2022
houhuayong
pushed a commit
to houhuayong/engine
that referenced
this pull request
Jun 21, 2022
…3100) * [Linux] read settings from XDG desktop portal if available Fixes: flutter/flutter#101438
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
FlSettingsPortalthat implements theFlSettingsinterface for the XDG desktop portal settings. On older systems where the portal is not available, the currentGSettings-based implementation is used. This fixes the issue that Flutter would not detect dark system themes in many desktop environments such as GNOME 42 or later, and KDE.Replaces: #32456
Fixes: flutter/flutter#101438
Pre-launch Checklist
///).