This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Windows: Texture Registrar: Destroy textures on raster thread #33688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnschulze
force-pushed
the
windows-destroy-external-textures-on-raster-thread
branch
from
7592542 to
2848b11
Compare
cbracken
suggested changes
Jun 10, 2022
jnschulze
force-pushed
the
windows-destroy-external-textures-on-raster-thread
branch
3 times, most recently
from
6806eca to
a2dd035
Compare
cbracken
reviewed
Sep 8, 2022
shell/platform/common/client_wrapper/include/flutter/texture_registrar.h
Outdated
Show resolved
Hide resolved
cbracken
approved these changes
Sep 8, 2022
loic-sharma
reviewed
Sep 8, 2022
loic-sharma
reviewed
Sep 8, 2022
loic-sharma
reviewed
Sep 8, 2022
jnschulze
force-pushed
the
windows-destroy-external-textures-on-raster-thread
branch
from
3b96677 to
6e03fd3
Compare
loic-sharma
reviewed
Sep 8, 2022
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 33688, due to - The status or check suite Mac iOS Engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
jnschulze
force-pushed
the
windows-destroy-external-textures-on-raster-thread
branch
from
31e5c2f to
f105e5e
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 9, 2022
jnschulze
deleted the
windows-destroy-external-textures-on-raster-thread
branch
11 tasks
stuartmorgan-g
added a commit
to flutter/plugins
that referenced
this pull request
Sep 13, 2022
Rolls Flutter master to the version that first failed due to flutter/engine#33688 Updates the camera_windows mocks to include the new method so that the tests will compile on master. Fixes the blocked roll.
cfontas
pushed a commit
to cfontas/engine
that referenced
this pull request
Sep 14, 2022
Oleh-Sv
pushed a commit
to Oleh-Sv/engine
that referenced
this pull request
Sep 28, 2022
adam-harwood
pushed a commit
to adam-harwood/flutter_plugins
that referenced
this pull request
Nov 3, 2022
Rolls Flutter master to the version that first failed due to flutter/engine#33688 Updates the camera_windows mocks to include the new method so that the tests will compile on master. Fixes the blocked roll.
mauricioluz
pushed a commit
to mauricioluz/plugins
that referenced
this pull request
Jan 26, 2023
Rolls Flutter master to the version that first failed due to flutter/engine#33688 Updates the camera_windows mocks to include the new method so that the tests will compile on master. Fixes the blocked roll.
engine-flutter-autoroll
pushed a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 22, 2023
Rolls Flutter master to the version that first failed due to flutter/engine#33688 Updates the camera_windows mocks to include the new method so that the tests will compile on master. Fixes the blocked roll.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with
FlutterWindowsTextureRegistrar::UnregisterTexturedestructing external textures on the calling thread as opposed to the raster thread which causes a potential crash upon callingglDeleteTexturesin the destructors of bothExternalTexturePixelBufferandExternalTextureD3d.Pre-launch Checklist
writing and running engine tests.
///).