Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[ci] Manually roll master #6418

Merged

Conversation

stuartmorgan-g
Copy link
Contributor

Rolls Flutter master to the version that first failed due to flutter/engine#33688

Updates the camera_windows mocks to include the new method so that the tests will compile on master.

Fixes the blocked roll.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass

Thanks for working on this! I've been trying all morning to get the windows tests to exclude camera_windows 🤦

@stuartmorgan-g
Copy link
Contributor Author

I've been trying all morning to get the windows tests to exclude camera_windows 🤦

Filed flutter/flutter#111484 since this is probably the fourth or fifth time this has come up.

@stuartmorgan-g
Copy link
Contributor Author

stuartmorgan-g commented Sep 13, 2022

Master failure is flake; I'm going to land this manually so that it runs in parallel with re-running the flake to get the roller going again.

@stuartmorgan-g stuartmorgan-g merged commit 3cf0ec5 into flutter:main Sep 13, 2022
@stuartmorgan-g stuartmorgan-g deleted the windows-camera-mock-update branch September 13, 2022 16:25
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 14, 2022
adam-harwood pushed a commit to adam-harwood/flutter_plugins that referenced this pull request Nov 3, 2022
Rolls Flutter master to the version that first failed due to flutter/engine#33688

Updates the camera_windows mocks to include the new method so that the tests will compile on master.

Fixes the blocked roll.
mauricioluz pushed a commit to mauricioluz/plugins that referenced this pull request Jan 26, 2023
Rolls Flutter master to the version that first failed due to flutter/engine#33688

Updates the camera_windows mocks to include the new method so that the tests will compile on master.

Fixes the blocked roll.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants