This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Windows] Support native functions in test fixtures #35357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
requested review from
stuartmorgan-g,
loic-sharma,
a-wallen and
yaakovschectman
loic-sharma
reviewed
Aug 11, 2022
cbracken
force-pushed
the
win-native-functions
branch
2 times, most recently
from
e11ce62 to
0b1b05b
Compare
cbracken
force-pushed
the
win-native-functions
branch
from
0b1b05b to
7a5c051
Compare
cbracken
force-pushed
the
win-native-functions
branch
from
7a5c051 to
a7bb37e
Compare
Adds the ability to register native functions for use in test fixtures. This allows registering native C++ functions that can be invoked from Dart code to perform the following common actions: * Signal a waiting latch in the C++ part of the test. * Pass data back to the C++ part of the test. * Allow the C++ part of the test to pass data to the test. Fixes: flutter/flutter#109242 Fixes: flutter/flutter#87299
cbracken
force-pushed
the
win-native-functions
branch
from
a7bb37e to
89906de
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to register native functions for use in test fixtures.
This allows registering native C++ functions that can be invoked from
Dart code to perform the following common actions:
Fixes: flutter/flutter#109242
Fixes: flutter/flutter#87299
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.