This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Delay the window until the first frame is received from the Flutter engine #54703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on a patch by jane400
Co-authored-by: Loïc Sharma <[email protected]>
|
@cbracken @loic-sharma this is ready to review/land now the FlApplication change has landed. |
cbracken
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Overall the change itself lgtm. Do you have a means of testing this?
I suspect that may be quite difficult due to the lack of support for fixture tests on Linux, but if you can think of a way to do it regardless, we should. If this is infeasible without fixture tests, you could request a test exemption with that justification.
I do think it would be valuable to add fixture test support for Linux. I don't have bandwidth to do so right now, but I did it for Windows a while back (#35273 and #35357).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 17, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 17, 2024
…155280) flutter/engine@04bc90b...a328f23 2024-09-16 [email protected] Roll Skia from 68eeaa5e20dc to d78293574d12 (2 revisions) (flutter/engine#55245) 2024-09-16 [email protected] Delay the window until the first frame is received from the Flutter engine (flutter/engine#54703) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#151098
This depends on #54637, so only the final commit is worth reviewing at this time. I'll rebase the branch once the FlApplication change lands.