Run clang tidy builds on arm Macs #41183
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -383,7 +383,8 @@ targets: | |
| recipe: engine/engine_lint | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| cores: "8" | ||
|
There was a problem hiding this comment. This dimension should be removed, but when I do the try falls back to 12 in the upstreamed config and fails with no resource https://chromium-swarm.appspot.com/task?id=619612e614a28f10&o=true&w=true. The ones in prod are also 8 core so this should still run there. I'll remove it when the config syncs after merging. There was a problem hiding this comment. Yeah, all arms are with 8 cores. Why not removing the cores from this PR? There was a problem hiding this comment.
When I remove it the build fails with resource unavailable: https://chromium-swarm.appspot.com/task?id=619612e614a28f10&o=true&w=true. I assumed it's not passing in "no cores", it's falling back to the synced config that says 12? I was thinking I would merge this and then try to remove the cores part in a future PR. There was a problem hiding this comment. I'm going to merge this and then remove the cores dimension in the next PR. I'll add you as a reviewer. |
||
| cpu: arm64 | ||
| lint_host: "true" | ||
| lint_ios: "false" | ||
| timeout: 75 | ||
|
|
@@ -405,6 +406,7 @@ targets: | |
| recipe: engine/engine_lint | ||
| properties: | ||
| add_recipes_cq: "true" | ||
| cpu: arm64 | ||
| lint_host: "false" | ||
| lint_ios: "true" | ||
| timeout: 75 | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The arm bots have 8 cores but should still be pretty fast.