Run clang tidy builds on arm Macs #41183
Conversation
| @@ -383,7 +383,7 @@ targets: | |||
| recipe: engine/engine_lint | |||
| properties: | |||
| add_recipes_cq: "true" | |||
| cores: "12" | |||
There was a problem hiding this comment.
The arm bots have 8 cores but should still be pretty fast.
| @@ -383,7 +383,8 @@ targets: | |||
| recipe: engine/engine_lint | |||
| properties: | |||
| add_recipes_cq: "true" | |||
| cores: "12" | |||
| cores: "8" | |||
There was a problem hiding this comment.
This dimension should be removed, but when I do the try falls back to 12 in the upstreamed config and fails with no resource https://chromium-swarm.appspot.com/task?id=619612e614a28f10&o=true&w=true.
The ones in prod are also 8 core so this should still run there. I'll remove it when the config syncs after merging.
There was a problem hiding this comment.
Yeah, all arms are with 8 cores. Why not removing the cores from this PR?
There was a problem hiding this comment.
Yeah, all arms are with 8 cores. Why not removing the cores from this PR?
When I remove it the build fails with resource unavailable: https://chromium-swarm.appspot.com/task?id=619612e614a28f10&o=true&w=true.
I assumed it's not passing in "no cores", it's falling back to the synced config that says 12? I was thinking I would merge this and then try to remove the cores part in a future PR.
There was a problem hiding this comment.
I'm going to merge this and then remove the cores dimension in the next PR. I'll add you as a reviewer.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jmagman
added
autosubmit
…124896) flutter/engine@413e95d...e9739bc 2023-04-14 [email protected] [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 [email protected] [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 [email protected] Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 [email protected] Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 [email protected] Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 [email protected] Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 [email protected] Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#124896) flutter/engine@413e95d...e9739bc 2023-04-14 [email protected] [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 [email protected] [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 [email protected] Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 [email protected] Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 [email protected] Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 [email protected] Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 [email protected] Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Intel Mac capacity is limited. Swap the two Mac clang-tidy builders to arm bots. The clang-tidy linter should run with arm natively.
Mac Host clang-tidy
Prod x64: https://ci.chromium.org/p/flutter/builders/prod/Mac%20Host%20clang-tidy/3318 Execution 35 mins 2 secs
This PR arm: https://ci.chromium.org/p/flutter/builders/try/Mac%20Host%20clang-tidy/8087 Execution 36 mins 30 secs (this hit an Xcode cache miss which added 4 minutes)
Mac iOS clang-tidy
Prod x64: https://ci.chromium.org/p/flutter/builders/prod/Mac%20iOS%20clang-tidy/3303 Execution 11 mins 57 secs
This PR arm: https://ci.chromium.org/p/flutter/builders/try/Mac%20iOS%20clang-tidy/8087 Execution 18 mins 10 secs (this hit an Xcode cache miss which added 5 minutes)