This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Allow Mac ci builders to run on arm #41187
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jmagman
commented
Apr 14, 2023
| @@ -338,6 +338,7 @@ targets: | |||
| {"download_emsdk": true} | |||
| add_recipes_cq: "true" | |||
| build_host: "true" | |||
| cpu: x86 # https://github.com/flutter/flutter/issues/124877 | |||
There was a problem hiding this comment.
Specifying Macmini8,1 Intel machine, see flutter/flutter#124877.
| @@ -372,6 +373,7 @@ targets: | |||
| recipe: engine/engine_unopt | |||
| properties: | |||
| add_recipes_cq: "true" | |||
| cpu: x86 # https://github.com/flutter/flutter/issues/124877 | |||
jmagman
changed the title
jmagman
commented
Apr 14, 2023
| @@ -52,7 +52,7 @@ platform_properties: | |||
| {"dependency": "open_jdk", "version": "version:11"} | |||
| ] | |||
| device_type: none | |||
| cpu: x86 | |||
| cpu: arm64 | |||
There was a problem hiding this comment.
Once the arm tests all pass, this will be removed so the scheduler can choose either arm64 or x64 depending on capacity.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we wouldn't specify a cpu except for the builders that needed either Intel or arm specifically, respectively, and let the scheduler figure out which bots to run based on capacity.
Allow all the Mac .ci.yaml builders (not ci/builders) on arm Macs. Pin the ones to x64 that need to for one reason or another.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.