This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Build unittests on all macOS host builds #41215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
mac-unittests-is_mac
branch
from
7fb4d1b to
a5076dc
Compare
|
I did consider |
zanderso
reviewed
Apr 14, 2023
Whether we're building an x64 or arm64 macOS host build, always build unit tests. Also removes the --enable-unittests gn config option since it was added specifically for macOS in flutter#40242. Issue: flutter/flutter#124840
cbracken
force-pushed
the
mac-unittests-is_mac
branch
from
a5076dc to
72cb398
Compare
zanderso
approved these changes
Apr 14, 2023
cbracken
added
the
autosubmit
dnfield
approved these changes
Apr 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 14, 2023
…124896) flutter/engine@413e95d...e9739bc 2023-04-14 [email protected] [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 [email protected] [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 [email protected] Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 [email protected] Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 [email protected] Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 [email protected] Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 [email protected] Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to exaby73/flutter_nevercode
that referenced
this pull request
Apr 17, 2023
…lutter#124896) flutter/engine@413e95d...e9739bc 2023-04-14 [email protected] [macOS] Build unittests on all macOS host builds (flutter/engine#41215) 2023-04-14 [email protected] [web] Don't run goldctl init more than once (flutter/engine#41207) 2023-04-14 [email protected] Roll Skia from 2bd12e31d578 to 22e417bea884 (4 revisions) (flutter/engine#41213) 2023-04-14 [email protected] Revert "[Android] Send connectionClosed message when keyboard becomes invisible to ensure framework focus state is correct." (flutter/engine#41211) 2023-04-14 [email protected] Remove `Mac mac_android_aot_engine` in favor of Linux (flutter/engine#41210) 2023-04-14 [email protected] Run clang tidy builds on arm Macs (flutter/engine#41183) 2023-04-14 [email protected] Roll Fuchsia Linux SDK from diD1gLr_dKWFJlsSn... to Z0of2S9pf3Zn1nsJP... (flutter/engine#41209) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from diD1gLr_dKWF to Z0of2S9pf3Zn If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether we're building an x64 or arm64 macOS host build, always build unit tests.
Issue: flutter/flutter#124840
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.