This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove cores dimension from Mac Host clang-tidy #41214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanderso
approved these changes
Apr 14, 2023
jmagman
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 15, 2023
…124900) flutter/engine@e9739bc...f794529 2023-04-14 [email protected] Change v2 `mac_unopt` orchestrator builder to Linux (flutter/engine#41184) 2023-04-14 [email protected] Specify allowed Macmini models (flutter/engine#41219) 2023-04-14 [email protected] Migrate mac_host_engine to engine v2 builds. (flutter/engine#41149) 2023-04-14 [email protected] Remove cores dimension from Mac Host clang-tidy (flutter/engine#41214) 2023-04-14 [email protected] Run mac_host_engine orchestrator on arm Macs (flutter/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
exaby73
pushed a commit
to NevercodeHQ/flutter
that referenced
this pull request
Apr 17, 2023
…lutter#124900) flutter/engine@e9739bc...f794529 2023-04-14 [email protected] Change v2 `mac_unopt` orchestrator builder to Linux (flutter/engine#41184) 2023-04-14 [email protected] Specify allowed Macmini models (flutter/engine#41219) 2023-04-14 [email protected] Migrate mac_host_engine to engine v2 builds. (flutter/engine#41149) 2023-04-14 [email protected] Remove cores dimension from Mac Host clang-tidy (flutter/engine#41214) 2023-04-14 [email protected] Run mac_host_engine orchestrator on arm Macs (flutter/engine#41185) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41183. Remove the
coresdimensions so this builder can run on any arm machine which currently all have 8 cores but there's no reason to specify now that the arch is arm.Introduced in #38261 to avoid 4-core Intel machines.