Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Include dart vm internal sources into flutter distro. #50116

Merged
merged 4 commits into from
Jan 29, 2024

Conversation

aam
Copy link
Member

@aam aam commented Jan 27, 2024

Missing sources are needed for better flutter IDE debugging experience.

Fixes flutter/flutter#128880

@aam aam requested a review from jonahwilliams January 29, 2024 18:59
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aam aam added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2024
@auto-submit auto-submit bot merged commit cca222b into flutter:main Jan 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 29, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jan 29, 2024
…142478)

flutter/engine@9c3ebf6...bedafa8

2024-01-29 [email protected] Roll Skia from f3b9e80d262a to 3680286e6bf4 (2 revisions) (flutter/engine#50149)
2024-01-29 [email protected] Handle construction/destruction of GObject private data containing C++ objects in Linux embedder tests (flutter/engine#50022)
2024-01-29 [email protected] Include dart vm internal sources into flutter distro. (flutter/engine#50116)
2024-01-29 [email protected] Manually revert TLHC optimizations, holding on to width/height changes. (flutter/engine#50144)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Debug adapter maps some file paths to the wrong location
2 participants