This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Manually revert TLHC optimizations, holding on to width/height changes. #50144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanlurey
changed the title
matanlurey
added
the
autosubmit
|
/cc @stuartmorgan @johnmccutchan /cc also @zanderso @dnfield, to add as an example of "the engine [CI] doesn't catch engine bugs". |
In this case the framework CI didn't catch it either; we may want to create a simple flutter/flutter integration test for that can repro it and add it there (sounds like probably an integration test with a trivial app containing a platform view that it resizes). |
Totally. I've added it as a check item here: flutter/flutter#142006. |
5 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 29, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jan 29, 2024
…142478) flutter/engine@9c3ebf6...bedafa8 2024-01-29 [email protected] Roll Skia from f3b9e80d262a to 3680286e6bf4 (2 revisions) (flutter/engine#50149) 2024-01-29 [email protected] Handle construction/destruction of GObject private data containing C++ objects in Linux embedder tests (flutter/engine#50022) 2024-01-29 [email protected] Include dart vm internal sources into flutter distro. (flutter/engine#50116) 2024-01-29 [email protected] Manually revert TLHC optimizations, holding on to width/height changes. (flutter/engine#50144) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #50065 due to flutter/flutter#142459.
Discord:
I manually merged this to keep #50066.