This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove migration flag and unused header files #50216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
force-pushed
the
remove-migration-flag
branch
2 times, most recently
from
21d2631 to
05d4f6a
Compare
LongCatIsLooong
force-pushed
the
remove-migration-flag
branch
from
05d4f6a to
6fc9776
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
jason-simmons
approved these changes
Jan 31, 2024
|
There doesn't seem to be any actual golden changes on the triage page. Removed the label. |
LongCatIsLooong
added
will affect goldens
autosubmit
|
Golden file changes are available for triage from new commit, Click here to view. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
|
This is breaking customer testing on the roll to the framework: https://ci.chromium.org/ui/p/flutter/builders/try/Mac%20customer_testing/69524/overview. I'm going to revert. The customer test can be migrated out-of-band. |
zanderso
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
Feb 1, 2024
This reverts commit 5f380ff.
8 tasks
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Feb 1, 2024
Reverts #50216 Initiated by: zanderso This change reverts the following previous change: Original Description: The `applyRoundingHack` flag is no longer used by the framework. This also removes the [lib/ui/text/line_metrics.h](https://github.com/flutter/engine/pull/50216/files#diff-9175619f2b114dffef67eba38511b34afe6abefd4f697f4758647133895b34f5) file which doesn't seem to be referenced anywhere. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 1, 2024
…142690) flutter/engine@f4fbabf...68943af 2024-02-01 [email protected] [Impeller] Clear the GPUTracerVK in_frame flag when ending a frame even if the tracer is disabled (flutter/engine#50228) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove migration flag and unused header files" (flutter/engine#50229) 2024-02-01 [email protected] [Impeller] size vk swapchain to window size. (flutter/engine#50205) 2024-02-01 [email protected] Remove string field from FlKeyEvent (flutter/engine#50189) 2024-02-01 [email protected] Roll Skia from 19e5e8f089b2 to bcbc172f74da (2 revisions) (flutter/engine#50226) 2024-02-01 [email protected] Ignore CRLF endings when determining the names of header guards. (flutter/engine#50227) 2024-02-01 [email protected] [Impeller] make GPU tracing off by default. (flutter/engine#50215) 2024-02-01 [email protected] Multiview: Add view ID to _render and remove render rule skipping (flutter/engine#50220) 2024-02-01 [email protected] Remove migration flag and unused header files (flutter/engine#50216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong
added a commit
to LongCatIsLooong/engine
that referenced
this pull request
Feb 1, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Forgot to update a pinned dependency in the previous attempt: flutter/tests#340 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
applyRoundingHackflag is no longer used by the framework. This also removes the lib/ui/text/line_metrics.h file which doesn't seem to be referenced anywhere.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.