This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Ignore CRLF endings when determining the names of header guards. #50227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
Feb 1, 2024
matanlurey
added
the
autosubmit
|
auto label is removed for flutter/engine/50227, due to - The status or check suite Linux linux_web_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
|
This has nothing to do with the flakes and tree redness, so I'm landing it anyway. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 1, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 1, 2024
…142690) flutter/engine@f4fbabf...68943af 2024-02-01 [email protected] [Impeller] Clear the GPUTracerVK in_frame flag when ending a frame even if the tracer is disabled (flutter/engine#50228) 2024-02-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove migration flag and unused header files" (flutter/engine#50229) 2024-02-01 [email protected] [Impeller] size vk swapchain to window size. (flutter/engine#50205) 2024-02-01 [email protected] Remove string field from FlKeyEvent (flutter/engine#50189) 2024-02-01 [email protected] Roll Skia from 19e5e8f089b2 to bcbc172f74da (2 revisions) (flutter/engine#50226) 2024-02-01 [email protected] Ignore CRLF endings when determining the names of header guards. (flutter/engine#50227) 2024-02-01 [email protected] [Impeller] make GPU tracing off by default. (flutter/engine#50215) 2024-02-01 [email protected] Multiview: Add view ID to _render and remove render rule skipping (flutter/engine#50220) 2024-02-01 [email protected] Remove migration flag and unused header files (flutter/engine#50216) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported by @loic-sharma.
The tl;dr is it should be OK to have
\r\n(CRLF) endings if the header guard is otherwise correct.This minor refactor (and test) discounts the existence of
\rwhen determining the name of a header guard, i.e.:... is now (correctly) considered a value of
FLUTTER_MATAN_WHY_H_notFLUTTER_MATAN_WHY_H_\r.