This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Temporarily change canvaskit kitchensink test to unblock the skia roll #50617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LongCatIsLooong
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2024
…143417) flutter/engine@abb51c4...c0607a0 2024-02-14 [email protected] Temporarily change canvaskit kitchensink test to unblock the skia roll (flutter/engine#50617) 2024-02-13 [email protected] [Impeller] add benchmarks for the stroke geometry entity code (flutter/engine#50616) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
Undo #50617 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous skia roll (#50609) failed on Linux linux_web_engine.
I've tested that the failing
canvaskit_api_tt_on_test.dartwould pass with the new skia revision'a1c58c4eb6d5ae553097c5d27c134e09c8825e06on this patch.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.