-
Notifications
You must be signed in to change notification settings - Fork 6k
Turn struct half leading in canvaskit kitchensink test back on #50707
Turn struct half leading in canvaskit kitchensink test back on #50707
Conversation
…tIsLooong/engine into kitchen-sink-strut-halfleading-on
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Golden file changes are available for triage from new commit, Click here to view. |
…146005) flutter/engine@8480145...32c9dab 2024-03-29 [email protected] Turn struct half leading in canvaskit kitchensink test back on (flutter/engine#50707) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Undo #50617
Pre-launch Checklist
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.