This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adds githooks that reminds to run gclient sync -D
#51156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
zanderso
force-pushed
the
post-merge-hook
branch
2 times, most recently
from
e667402 to
8d3e86b
Compare
|
This change needs a little extra code to support |
zanderso
force-pushed
the
post-merge-hook
branch
from
8d3e86b to
92836b2
Compare
zanderso
changed the title
gclient sync -Dgclient sync -D
jason-simmons
approved these changes
Mar 4, 2024
zanderso
force-pushed
the
post-merge-hook
branch
from
92836b2 to
8832caa
Compare
dkwingsmt
reviewed
Mar 5, 2024
| final String postfix = io.stdout.supportsAnsiEscapes ? _reset : ''; | ||
| io.stderr.writeln('$command: The engine source tree has been updated.'); | ||
| io.stderr.writeln( | ||
| '\n${prefix}You man need to run "gclient sync -D"$postfix\n', |
There was a problem hiding this comment.
Typo?
'\n${prefix}You may need to run "gclient sync -D"$postfix\n',
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2024
…144639) flutter/engine@3e8b0de...49bc157 2024-03-05 [email protected] Fix typo in githook message (flutter/engine#51205) 2024-03-05 [email protected] Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202) 2024-03-05 [email protected] Add device selection to `et run` (flutter/engine#51184) 2024-03-05 [email protected] Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201) 2024-03-05 [email protected] Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Mar 5, 2024
Windows does not pre-install python3. Previously Windows users would just use Python from depot tools, but this was broken by #51156.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds githooks for
post-checkout,post-merge,pre-rebasethat remind to rungclient sync -D. This is probably going to print the reminder too much. Thepre-rebasehook runs before agit pull --rebasethat is actually going to update something, but the other hooks may be needed to cover other workflows. The printed message will also include the hook that it comes from, so we can remove the message from hooks where it doesn't make sense.