-
Notifications
You must be signed in to change notification settings - Fork 6k
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
Whoops. Can you verify that this still works on mac and Linux? |
@zanderso Verified.
Sorry for the delay, I didn't have a Linux machine setup at the office. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
test-exempt: we'll find out about this being broken really quickly when it matters |
…144653) flutter/engine@49bc157...effcf97 2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (#51209)" (flutter/engine#51217) 2024-03-05 [email protected] [Impeller] implement blur style solid (flutter/engine#50892) 2024-03-05 [email protected] [g3 roll] Revert "Remove unused drone_dimension field" (flutter/engine#51214) 2024-03-05 [email protected] Roll Skia from 17677914dabf to 37947aec8c5c (5 revisions) (flutter/engine#51211) 2024-03-05 [email protected] Fix git hooks on Windows (flutter/engine#51203) 2024-03-05 [email protected] [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#51209) 2024-03-05 [email protected] [Impeller] Fix convex triangulation winding bug for multi-contour paths. (flutter/engine#51198) 2024-03-05 [email protected] Roll Skia from 875b356e4d96 to 17677914dabf (2 revisions) (flutter/engine#51207) 2024-03-05 [email protected] Skip configuration dependency if unit tests are disabled (flutter/engine#51179) 2024-03-05 [email protected] [Impeller] Implement YUV texture import and sampling for video player frames. (flutter/engine#50730) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Windows does not pre-install python3. Previously Windows users would just use Python from depot tools, but this was broken by #51156.