[Impeller] moved to bgra10_xr

[gaaclarke]

fixes flutter/flutter#145933

This required that we moved the golden image tests to arm64 since the wide gamut tests would now require BGRA10_XR and that's only available to arm64.

tests: in framework repo https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test. There was a test added to that suite specifically for this case when we turned off BGRA10_XR the first time.

This has a dependency on #51998 which includes the necessary skia change.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
• I listed at least one issue that this PR fixes in the description above.
• I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
• I updated/added relevant documentation (doc comments with ///).
• I signed the CLA.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gaaclarke]

This passes the flutter wide gamut tests locally: https://github.com/flutter/flutter/tree/master/dev/integration_tests/wide_gamut_test

[gaaclarke]

The failure seems to be related to using the bgra10_xr format on the CI machine. It passes locally on my machine, this may be a limit to their GPU?

[ RUN      ] Play/AiksTest.BlendModePlusAlphaColorFilterWideGamut/Metal
2024-04-10 08:45:52.059 impeller_unittests[68274:476517] *** Terminating app due to uncaught exception 'CAMetalLayerInvalid', reason: 'unsupported extended range format'
*** First throw call stack:
(
	0   CoreFoundation                      0x00007ff80e3c011a __exceptionPreprocess + 242
	1   libobjc.A.dylib                     0x00007ff80dee60b7 objc_exception_throw + 48
	2   CoreFoundation                      0x00007ff80e3bff80 +[NSException raise:format:] + 214
	3   QuartzCore                          0x00007ff815bfc3c1 -[CAMetalLayer setPixelFormat:] + 339
	4   impeller_unittests                  0x0000000109bf62a2 _ZN8impeller17PlaygroundImplMTLC2ENS_18PlaygroundSwitchesE + 2210
	5   impeller_unittests                  0x0000000109bf4cce _ZN8impeller14PlaygroundImpl6CreateENS_17PlaygroundBackendENS_18PlaygroundSwitchesE + 94
	6   impeller_unittests                  0x0000000109bf15a4 _ZN8impeller10Playground12SetupContextENS_17PlaygroundBackendERKNS_18PlaygroundSwitchesE + 132
	7   impeller_unittests                  0x000000010a2dc0d6 _ZN8impeller14PlaygroundTest5SetUpEv + 262
	8   impeller_unittests                  0x000000010a58f4c3 _ZN7testing4Test3RunEv + 163
	9   impeller_unittests                  0x000000010a590537 _ZN7testing8TestInfo3RunEv + 343
	10  impeller_unittests                  0x000000010a5911c5 _ZN7testing9TestSuite3RunEv + 805
	11  impeller_unittests                  0x000000010a59fedd _ZN7testing8internal12UnitTestImpl11RunAllTestsEv + 1101
	12  impeller_unittests                  0x000000010a59fa0b _ZN7testing8UnitTest3RunEv + 123
	13  impeller_unittests                  0x0000000109ccd37d main + 445
	14  dyld                                0x00007ff80df1341f start + 1903
)
libc++abi: terminating due to uncaught exception of type NSException

[gaaclarke]

@chinmaygarde @jonahwilliams this is ready for review now, please don't land it until I get back into the office though.

[jonahwilliams]

Overall LGTM, I'd want @zanderso to double check the CI configs though

[gaaclarke]

Overall LGTM, I'd want @zanderso to double check the CI configs though

Zach is out of office for a minute so I'm going to land this.

[auto-submit]

A reason for requesting a revert of flutter/engine/52019 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

[jonahwilliams]

Reason for revert: I believe the tree failures are due to changes in the build configuration this file introduced.

[gaaclarke]

I believe the failure is https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/313368/overview

[jonahwilliams]

See also: https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/313370/overview

[gaaclarke]

Mac Production Engine - Release

link

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/313370/infra

error

[ RUN      ] Play/AiksTest.CanRenderAdvancedBlendColorFilterWithSaveLayer/Vulkan
[ERROR:flutter/impeller/playground/backend/vulkan/playground_impl_vk.cc(224)] Attempting to initialize a Vulkan playground on macOS where Vulkan cannot be found. It can be installed via MoltenVK and make sure to install it globally so dlopen can find it.
[FATAL:flutter/impeller/playground/playground_impl.cc(40)] Check failed: false. Attempted to create playground with backend that isn't available or was disabled on this platform: Vulkan
[ERROR:flutter/fml/backtrace.cc(108)] Caught signal SIGABRT during program execution.
Frame 0: 0x100d830dc fml::LogMessage::~LogMessage()
Frame 1: 0x100d830cc fml::LogMessage::~LogMessage()
Frame 2: 0x101018e1c impeller::PlaygroundImpl::Create()
Frame 3: 0x101130490 impeller::(anonymous namespace)::MakeVulkanPlayground()
Frame 4: 0x10112f060 impeller::GoldenPlaygroundTest::SetUp()
Frame 5: 0x101148d14 testing::Test::Run()
Frame 6: 0x101149e8c testing::TestInfo::Run()
Frame 7: 0x10114aafc testing::TestSuite::Run()
Frame 8: 0x101159828 testing::internal::UnitTestImpl::RunAllTests()
Frame 9: 0x1011593a8 testing::UnitTest::Run()
Frame 10: 0x100c79598 main
Frame 11: 0x194ffbf28 start

evaluation

This happens when swiftshader isn't available to the test runner. I had to fix this for some of the presubmit steps. There are 2 variables that seem to effect this:

1. The gn flag --use-glfw-swiftshader
2. The presence of libvk_swiftshader.dylib in the output directory. I copied what we had for x64 but it seems like there isn't an explicit dependency on swiftshader so it is possible to build the test runner without building swiftshader.

Mac Production Engine - Debug

link

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20Production%20Engine%20Drone/313368/overview

error

[4943/7663] CXX obj/third_party/libcxx/src/filesystem/libcxx.operations.o
FAILED: obj/third_party/libcxx/src/filesystem/libcxx.operations.o 
../../../flutter/buildtools/mac-x64/clang/bin/clang++ -MMD -MF obj/third_party/libcxx/src/filesystem/libcxx.operations.o.d -D_LIBCPP_NO_EXCEPTIONS -D_LIBCPP_NO_RTTI -D_LIBCPP_BUILDING_LIBRARY -DLIBCXX_BUILDING_LIBCXXABI -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D_LIBCPP_DISABLE_AVAILABILITY=1 -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS -D_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -I../../.. -Igen -I../../../third_party/libcxx/include -I../../../third_party/libcxxabi/include -I../../../flutter/build/secondary/third_party/libcxx/config -I../../../third_party/libcxx/src -fno-strict-aliasing -fstack-protector-all --target=arm64-apple-macos -arch arm64 -fcolor-diagnostics -Wall -Wextra -Wendif-labels -Werror -Wno-missing-field-initializers -Wno-unused-parameter -Wno-unused-but-set-parameter -Wno-unused-but-set-variable -Wno-implicit-int-float-conversion -Wno-deprecated-copy -Wno-psabi -Wno-deprecated-literal-operator -Wno-unqualified-std-cast-call -Wno-non-c-typedef-for-linkage -Wno-range-loop-construct -Wunguarded-availability -Wno-deprecated-declarations -fvisibility=hidden -Wstring-conversion -Wnewline-eof -O2 -fno-ident -fdata-sections -ffunction-sections -g2 -Wno-thread-safety-analysis -fvisibility-inlines-hidden -nostdinc++ -nostdinc++ -fvisibility=hidden -fno-exceptions -stdlib=libc++ -std=c++20 -isysroot ../../../../../osx_sdk/xcode_15a240d/XCode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.0.sdk -mmacosx-version-min=10.14.0  -c ../../../third_party/libcxx/src/filesystem/operations.cpp -o obj/third_party/libcxx/src/filesystem/libcxx.operations.o
clang++: error: clang frontend command failed with exit code 139 (use -v to see invocation)
Fuchsia clang version 18.0.0 (https://llvm.googlesource.com/llvm-project 725656bdd885483c39f482a01ea25d67acf39c46)
Target: arm64-apple-macos
Thread model: posix
InstalledDir: /Volumes/Work/s/w/ir/cache/builder/src/out/ci/mac_debug_arm64/../../../flutter/buildtools/mac-x64/clang/bin
clang++: note: diagnostic msg: 
********************

PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang++: note: diagnostic msg: /Volumes/Work/s/w/ir/x/w/recipe_cleanup/tmpyiytyz5o/operations-73c986.cpp
clang++: note: diagnostic msg: /Volumes/Work/s/w/ir/x/w/recipe_cleanup/tmpyiytyz5o/operations-73c986.sh
clang++: note: diagnostic msg: Crash backtrace is located in
clang++: note: diagnostic msg: /Users/chrome-bot/Library/Logs/DiagnosticReports/llvm_<YYYY-MM-DD-HHMMSS>_<hostname>.crash
clang++: note: diagnostic msg: (choose the .crash file that corresponds to your crash)
clang++: note: diagnostic msg: 

********************

evaluation

This is a crash in the complier when compiling files unrelated to this PR for arm64. I am surprised that this would cause things to be compiled for arm64 that were not already compiled for arm64 for debug builds since I the golden tests who were moved to arm64 should be release only builds.

I did notice that the failure is when cross-compiling on an x64 machine to arm64. We might be able to fix that problem by moving to an arm64 machine.

---

I'm not sure what Mac Production Engine's are, but hopefully we can get them running in presubmit when we reland this.

[jonahwilliams]

I think the clang crash is an ongoing issue related to the goma / RBE migration

[gaaclarke]

I think the clang crash is an ongoing issue related to the goma / RBE migration

I accidentally submitted my comment before it was finished. I updated it. I hypothesize that we can git rid of that crash by moving that bot to an arm64 mac. Right now it's cross compiling for arm64 on x64.