Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Relands "[Impeller] moved to bgra10_xr (#52019)" #52142

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Apr 15, 2024

relands #52019

Patch addresses the compilation problem noted in #52019 (comment)

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@gaaclarke gaaclarke marked this pull request as ready for review April 16, 2024 00:09
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2024
@auto-submit auto-submit bot merged commit 66ad802 into flutter:main Apr 16, 2024
33 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 16, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Apr 16, 2024
…146794)

flutter/engine@76fbe31...66ad802

2024-04-16 [email protected] Relands "[Impeller] moved to bgra10_xr (#52019)" (flutter/engine#52142)
2024-04-16 [email protected] Roll Skia from f6a2a2af83f1 to b159229f2174 (1 revision) (flutter/engine#52143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
…lutter#146794)

flutter/engine@76fbe31...66ad802

2024-04-16 [email protected] Relands "[Impeller] moved to bgra10_xr (flutter#52019)" (flutter/engine#52142)
2024-04-16 [email protected] Roll Skia from f6a2a2af83f1 to b159229f2174 (1 revision) (flutter/engine#52143)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App e: impeller platform-ios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants