Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

reidbaker
Copy link
Contributor

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

- Destroy ImageReaders on memory trim.
- Unset the VirtualDisplay's surface on memory trim.
- On resume, recreate ImageReaders.
- On resume, do a dumb little dance and then set the VirtualDisplay's surface

Fixes: flutter/flutter#146499
Fixes: flutter/flutter#144219

Internal bug: b/335646931
Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418

Android 15 will include the fix. Unclear if Android 14 will be patched.
@reidbaker reidbaker requested a review from johnmccutchan April 30, 2024 18:24
@reidbaker reidbaker changed the title Workaround HardwareRenderer breakage in Android 14 (#52370) Stable/3.19 CP Workaround HardwareRenderer breakage in Android 14 (#52370) Apr 30, 2024
@reidbaker
Copy link
Contributor Author

After a few attempts and discussing the code with @johnmccutchan we decided we cant land this cleanly or safely into 3.19.

@reidbaker reidbaker closed this May 1, 2024
@reidbaker reidbaker deleted the i52370-3.19-cp-attempt2 branch May 1, 2024 14:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants