Workaround HardwareRenderer breakage in Android 14 #52370

johnmccutchan · 2024-04-24T20:49:30Z

Destroy ImageReaders on memory trim.
Unset the VirtualDisplay's surface on memory trim.
On resume, recreate ImageReaders.
On resume, do a dumb little dance and then set the VirtualDisplay's surface

Fixes: flutter/flutter#146499
Fixes: flutter/flutter#144219

Internal bug: b/335646931
Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418

Android 15 will include the fix. Unclear if Android 14 will be patched.

flutter-dashboard · 2024-04-24T20:49:33Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

jonahwilliams

:chef_kiss

reidbaker

This looks good but I would expect that we had a test at least calling clear/reset surface and one making sure that the onTrimMemory was forwarded to the PlatformViewsController.

shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java

shell/platform/android/io/flutter/embedding/android/FlutterActivityAndFragmentDelegate.java

shell/platform/android/io/flutter/plugin/platform/PlatformViewsController.java

reidbaker · 2024-04-29T14:05:34Z

Failing test is a trim memory test

engine/shell/platform/android/test/io/flutter/embedding/engine/renderer/FlutterRendererTest.java

Line 625 in fa48884

public void ImageReaderSurfaceProducerTrimMemoryCallback() {

shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java

gmackall · 2024-04-30T00:22:15Z

Tested the latest version of this patch with a repro app shared by @johnmccutchan, by backgrounding the app and then repeatedly opening and backgrounding the built in camera app. Looks like it is working to me! Didn't experience any instances of the breakage

- Destroy ImageReaders on memory trim. - Unset the VirtualDisplay's surface on memory trim. - On resume, recreate ImageReaders. - On resume, do a dumb little dance and then set the VirtualDisplay's surface Fixes: flutter/flutter#146499 Fixes: flutter/flutter#144219 Internal bug: b/335646931 Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418 Unclear when the Android fix will be available in phones.

…/engine#52370)

…147560) flutter/engine@c519e9d...ea63438 2024-04-30 [email protected] Workaround HardwareRenderer breakage in Android 14 (flutter/engine#52370) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

flutteractionsbot · 2024-04-30T14:35:12Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

- Destroy ImageReaders on memory trim. - Unset the VirtualDisplay's surface on memory trim. - On resume, recreate ImageReaders. - On resume, do a dumb little dance and then set the VirtualDisplay's surface Fixes: flutter/flutter#146499 Fixes: flutter/flutter#144219 Internal bug: b/335646931 Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418 Android 15 will include the fix. Unclear if Android 14 will be patched.

flutteractionsbot · 2024-05-01T14:06:22Z

Failed to create CP due to merge conflicts.
You will need to create the PR manually. See the cherrypick wiki for more info.

- Destroy ImageReaders on memory trim. - Unset the VirtualDisplay's surface on memory trim. - On resume, recreate ImageReaders. - On resume, do a dumb little dance and then set the VirtualDisplay's surface Fixes: flutter/flutter#146499 Fixes: flutter/flutter#144219 Internal bug: b/335646931 Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418 Android 15 will include the fix. Unclear if Android 14 will be patched.

- **Replace LinkedLists that are used as a queue in android FlutterRenderer with ArrayDeques (#51494)** - **Workaround HardwareRenderer breakage in Android 14 (#52370)** Fixes flutter/flutter#147644 Includes #51494 to avoid merge conflicts and have a cleaner merge.

johnmccutchan requested review from reidbaker and jonahwilliams April 24, 2024 20:49

github-actions bot added the platform-android label Apr 24, 2024

jonahwilliams approved these changes Apr 24, 2024

View reviewed changes

reidbaker approved these changes Apr 25, 2024

View reviewed changes

phcd30 mentioned this pull request Apr 26, 2024

TLHC platform views on Android 14/15 stop updating on resume flutter/flutter#146499

Closed

reidbaker reviewed Apr 29, 2024

View reviewed changes

shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java Show resolved Hide resolved

johnmccutchan force-pushed the image_reader_workaround branch 3 times, most recently from 8636f6e to f3c466d Compare April 29, 2024 23:18

johnmccutchan force-pushed the image_reader_workaround branch from f3c466d to f0a4719 Compare April 30, 2024 04:31

johnmccutchan added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 30, 2024

auto-submit bot merged commit ea63438 into flutter:main Apr 30, 2024
29 checks passed

engine-flutter-autoroll mentioned this pull request Apr 30, 2024

Roll Flutter Engine from c519e9dd182b to ea6343846c62 (1 revision) flutter/flutter#147560

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Apr 30, 2024

ea6343846 Workaround HardwareRenderer breakage in Android 14 (flutter…

8d84b9d

…/engine#52370)

reidbaker added the cp: stable cherry pick to the stable release candidate branch label Apr 30, 2024

reidbaker mentioned this pull request Apr 30, 2024

[CP] Workaround HardwareRenderer breakage in Android 14 flutter/flutter#147578

Closed

reidbaker mentioned this pull request Apr 30, 2024

Stable/3.19 CP Workaround HardwareRenderer breakage in Android 14 (#52370) #52463

Closed

8 tasks

reidbaker added the cp: beta cherry pick to the beta release candidate branch label May 1, 2024

reidbaker mentioned this pull request May 1, 2024

[CP] Beta/3.22 Platform view android 14 workaround flutter/flutter#147644

Closed

reidbaker mentioned this pull request May 1, 2024

[CP] Beta/3.22 Workaround for platform view android 14 #52489

Closed

8 tasks

reidbaker mentioned this pull request May 1, 2024

I52370 3.22.cp attempt2 #52491

Merged

8 tasks

huycozy mentioned this pull request Jul 5, 2024

[webview_flutter] The screen freezes when previewing selected images. (Observed only on Pixel 8) flutter/flutter#151088

Closed

matanlurey mentioned this pull request Feb 13, 2025

Respond to TRIM_MEMORY events for platform views, not textures. flutter/flutter#163179

Closed

j-kim-safie mentioned this pull request Mar 3, 2025

Text is broken on Samsung Galaxy flutter/flutter#164480

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Workaround HardwareRenderer breakage in Android 14 #52370

Workaround HardwareRenderer breakage in Android 14 #52370

Uh oh!

johnmccutchan commented Apr 24, 2024

Uh oh!

flutter-dashboard bot commented Apr 24, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

reidbaker left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 29, 2024

Uh oh!

Uh oh!

gmackall commented Apr 30, 2024

Uh oh!

Uh oh!

flutteractionsbot commented Apr 30, 2024

Uh oh!

flutteractionsbot commented May 1, 2024

Uh oh!

Uh oh!

Workaround HardwareRenderer breakage in Android 14 #52370

Workaround HardwareRenderer breakage in Android 14 #52370

Uh oh!

Conversation

johnmccutchan commented Apr 24, 2024

Uh oh!

flutter-dashboard bot commented Apr 24, 2024

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Apr 29, 2024

Uh oh!

Uh oh!

gmackall commented Apr 30, 2024

Uh oh!

Uh oh!

flutteractionsbot commented Apr 30, 2024

Uh oh!

flutteractionsbot commented May 1, 2024

Uh oh!

Uh oh!