This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[CP] Beta/3.22 Workaround for platform view android 14 #52489
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arget. (flutter#51736) I tested against a few example apps and found this case is actually very common. These full screen/pass clips render nothing to the depth buffer can be particularly troublesome in the presence of backdrop filters (due to clip replay). While this case doesn't actually result in anything getting written to the depth buffer, we still end up overwriting the entire stencil buffer twice: Once for the preparation draw, and again for the depth buffer transfer/stencil cleanup draw.
) https://skia.googlesource.com/skia.git/+log/c0e0b76d6d51..e25b0f9006a4 2024-03-28 [email protected] skia: Fix implicit conversion warning 2024-03-28 [email protected] [fontations] Add underline and strikeout metrics If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#51756) Relands flutter#51589 The fix is in 74397bc. I couldn't figure out how to get a test in the engine to cover it. The test is in the devicelab. Here's what I attempted: ```c++ TEST_P(AiksTest, BlendModePlusAlphaColorFilterAlphaWideGamut) { if (GetParam() != PlaygroundBackend::kMetal) { GTEST_SKIP_("This backend doesn't yet support wide gamut."); } EXPECT_EQ(GetContext()->GetCapabilities()->GetDefaultColorFormat(), PixelFormat::kR16G16B16A16Float); Canvas canvas; canvas.Scale(GetContentScale()); canvas.DrawPaint({.color = Color(0.1, 0.2, 0.1, 0.5)}); canvas.SaveLayer({ .color_filter = ColorFilter::MakeBlend(BlendMode::kPlus, Color(Vector4{1, 0, 0, 0.5})), }); Paint paint; paint.color = Color(1, 0, 0, 0.5); canvas.DrawRect(Rect::MakeXYWH(100, 100, 400, 400), paint); paint.color = Color::White(); canvas.Restore(); ASSERT_TRUE(OpenPlaygroundHere(canvas.EndRecordingAsPicture())); } ``` ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
Closes flutter/flutter#144064. From a conversation with @camsim99 on Discord: > Ah this was to debug that missing emulator issue (flutter/flutter#137947) that Ricardo and I were seeing. We wanted to see if it was specific to the API 34, and if so, escalate the issue internally. @ricardoamador Would you like to keep running the tests with API 33? You mentioned you have found a workaround, and the test runs seem to not have yielded any evidence against API 34.
Closes flutter/flutter#145926. This was likely left on by accident (if not, we should utilize `FLUTTER_LOGS_DIR` instead of this flag). /cc @zanderso
Closes flutter/flutter#141641. Basically, this should verify "it's possible to use VSCode+LSC, at least in theory". I'm open to writing a test, but given it _is_ a test I'm less sure it's valuable. Feel free to push back.
https://skia.googlesource.com/skia.git/+log/e25b0f9006a4..6042ad386bcf 2024-03-28 [email protected] [fontations] Respect aliasing If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
- `et query tests` enumerates all test binaries encoded in BUILD.gn files. - `et test` builds, then, runs a set of tests in parallel - Tests
…r#51761) Mipmaps are not working at all right now with Vulkan. Opening without fix so we see goldens changing.
flutter#51738) This PR groups per-view information in `FlutterCompositor` into a private class, `ViewPresenter`. This makes it easier to manage per-view data and write view operations. Part of flutter/flutter#145874. Currently, view presenters are never removed once created, since the macOS runner doesn't support removing views. This will be added in the future. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Currently destroying a view also shuts down the engine. This makes sense as in single-view world where the view also always owns the engine. However, in a multi-view world the views will share the engine. Destroying one view shouldn't necessarily shut down the engine unless that view owns the engine. Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Previously the keyboard was initialized after the view is created. This used to be necessary as the keyboard & text input plugins were strongly tied to a view (and would crash in headless modes). This is no longer necessary, and the keyboard can now be initialized normally as part of the engine initialization. Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
In the future, `FlutterEngineAddView` will be added to the embedder API to allow embedders to add views. `FlutterEngineAddView` will accept a callback that notifies the embedder once the view has been added. This embedder API will be powered by `Shell::AddView`. This change adds a completion callback to `Shell::AddView` to prepare for the embedder API. Design doc: https://flutter.dev/go/multi-view-embedder-apis Part of flutter/flutter#144806 Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
…lutter#51766) This fixes flutter/flutter#141639 Most of this was previously unimplemented. It turns out the reason for the hang described in the github issue was that there was a typo in the name of the `getMiterLimit` C function, so if the client actually called that method the Wasm module failed to compile, as it couldn't find an import with the misspelled name.
…... (flutter#51767) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/6042ad386bcf..b2a01ae03cdf 2024-03-29 [email protected] Roll Skia Infra from d9a2f3150285 to 33ace26e29f4 (9 revisions) 2024-03-29 [email protected] Roll Dawn from 8220ee868483 to 2126889e45aa (11 revisions) 2024-03-29 [email protected] Roll SwiftShader from f0178b3c40e7 to ff61926fcedb (2 revisions) 2024-03-29 [email protected] Roll vulkan-deps from 61c7aa9a8478 to f91c2fe47c47 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/b2a01ae03cdf..94c0af1297ae 2024-03-29 [email protected] Roll ANGLE from 21b6899a9c31 to 2b66694d37de (9 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/94c0af1297ae..a12e40efacea 2024-03-29 [email protected] fix indentation in SkBlitMask_opts.h 2024-03-29 [email protected] Remove deprecated hasMipMaps from GrBackendSurface 2024-03-29 [email protected] Roll SK Tool from 33ace26e29f4 to dc19502e745f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…51749) Uses the mipmap implementation from https://vulkan-tutorial.com/Generating_Mipmaps . Today we generate all mip levels from mip level 0, which results in lost data. Instead we need to use the previous mip level
Handle `viewId` for text fields. Part of flutter/flutter#137344
…lutter#51739) Work towards flutter/flutter#144835. Doc (_sorry, internal only_): [go/flutter-engine-goldens-workflow](http://goto.google.com/flutter-engine-goldens-workflow). This implements the majority of the proposed workflow, that is, optionally having a plain-text version at the root of the directory, and using it to apply a unique suffix we can review in release branches. As it stands, this is a NO-OP outside of tests (it will have no impact, and can be ignored). What's missing before using this feature in release branches: - Optimization work with the infra team (not sure if blocking or not): flutter/flutter#145842 - A dry-run of this with the release team to make sure it works as intended @gaaclarke As implemented, I _think_ we don't need anything special for [`dir_contents_diff`](https://github.com/flutter/engine/blob/b0d3663f439fd97c32bf4d46b9004c97841c43b8/tools/dir_contents_diff), but maybe I'm wrong - I think only the _test_ names are being changed, not the names on disk. /cc @zanderso as well.
Work towards flutter/flutter#133569. This PR is a proof of concept that shows we're able to use `package:test` in `flutter/engine` instead of `package:litetest`. I think it also shows that, if we're going to continue to vend dependencies this way, we might want to re-think our strategy in terms of using `pub` as a management tool - it's quite unwieldy already. For example, here is every `pubspec.yaml` file in the repo: ```sh $ find . -name 'pubspec.yaml' -exec sh -c 'echo "$0 $(wc -l < "$0")"' {} \; # Some files omitted in third_party or similar. ./impeller/tessellator/dart/pubspec.yaml 11 ./tools/const_finder/pubspec.yaml 35 ./tools/api_check/pubspec.yaml 90 ./tools/build_bucket_golden_scraper/pubspec.yaml 47 ./tools/licenses/pubspec.yaml 53 ./tools/path_ops/dart/pubspec.yaml 26 ./tools/engine_tool/pubspec.yaml 76 ./tools/dir_contents_diff/pubspec.yaml 19 ./tools/compare_goldens/pubspec.yaml 3 ./tools/golden_tests_harvester/pubspec.yaml 55 ./tools/gen_web_locale_keymap/pubspec.yaml 37 ./tools/githooks/pubspec.yaml 63 ./tools/android_lint/pubspec.yaml 35 ./tools/clang_tidy/pubspec.yaml 76 ./tools/pkg/engine_repo_tools/pubspec.yaml 41 ./tools/pkg/process_fakes/pubspec.yaml 36 ./tools/pkg/engine_build_configs/pubspec.yaml 73 ./tools/pkg/git_repo_tools/pubspec.yaml 60 ./tools/header_guard_check/pubspec.yaml 70 ./sky/packages/sky_engine/pubspec.yaml 8 ./shell/vmservice/pubspec.yaml 8 ./ci/pubspec.yaml 57 ./testing/benchmark/pubspec.yaml 77 ./testing/skia_gold_client/pubspec.yaml 66 ./testing/pkg_test_demo/pubspec.yaml 116 ./testing/smoke_test_failure/pubspec.yaml 31 ./testing/dart/pubspec.yaml 71 ./testing/android_background_image/pubspec.yaml 22 ./testing/litetest/pubspec.yaml 33 ./testing/symbols/pubspec.yaml 24 ./testing/scenario_app/pubspec.yaml 67 ./web_sdk/web_engine_tester/pubspec.yaml 14 ./web_sdk/web_test_utils/pubspec.yaml 22 ./web_sdk/pubspec.yaml 60 ./lib/snapshot/pubspec.yaml 8 ./lib/gpu/pubspec.yaml 14 ./lib/web_ui/pubspec.yaml 60 ./flutter_frontend_server/pubspec.yaml 39 ``` I'll file a follow-up issue to discuss pub-package management in the engine.
…er#50707) Undo flutter#50617 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Migrates the macOS embedder to the new present callback which includes a `view_id` value. Not much can be tested, since this doesn't change any features, nor add any features without the ability to add a view. But I added a test to verify that rendering to an unknown view is a graceful no-op. Design doc: https://flutter.dev/go/multi-view-embedder-apis Part of flutter/flutter#144810 Part of flutter/flutter#142845 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
…pp`. (flutter#51769) Closes flutter/flutter#145957. As @jonahwilliams and @johnmccutchan and I discussed (flutter/flutter#144407), the functionality that was being tested was actually _Android's_ ability to rotate and crop `SurfaceTexture`-backed textures. This same functionality doesn't even exist in the `ImageReader`-based textures (read: modern Android devices): > Due to an oversight by Android, ImageReader backed surfaces do not respect metadata applied to the surface (rotation & crop). Rotation information is not available at all and crop information is corrupted by the ImageReader (only the width/height is propagated the origin offset is not). We might decide to re-add this functionality in the Dart `Texture` widget, but given we'll be migrating our plugins to `SurfaceProducer` (again, read: using `ImageTexture` for most Android phones), it's pointless to test this (and isn't even testing Flutter's code). This reduces our test suite significantly (8 tests down to 2), which should also help with runtime and flakiness. /cc @zanderso who I'm sure will be stoked.
) As of flutter/flutter#121606 the flutter tool no longer registers for the legacy `_dartobservatory._tcp` DNS type. Remove the fallback and just register for the preferred `_dartVmService._tcp`. See also dart-lang/sdk#50233
Further work towards flutter/flutter#141641. I could imagine making things `presubmit: false` if we think it's not worth the presubmit capacity. Removed `:copy_dart_sdk` which seems (a) not to work and (b) not needed to use the pre-builts.
Further work towards flutter/flutter#141641.
https://skia.googlesource.com/skia.git/+log/7338f5521e05..ab0f4a038cec 2024-03-29 [email protected] [bazel] Rename //tools/window:window to //tools/window:legacy_window. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…1789) Work towards flutter/flutter#145988. ... as well as handle `sigTerm` (perhaps would help us actually write out logs? we'll see)
…#51794) https://dart.googlesource.com/sdk.git/+log/52b05146758e..572de60e008a 2024-03-29 [email protected] Version 3.5.0-3.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
) https://skia.googlesource.com/skia.git/+log/ab0f4a038cec..7dc399e01f98 2024-03-30 [email protected] [bazel] Define //tools/sk_app:sk_app modular build target. 2024-03-29 [email protected] [bazel] Define //tools/window:window modular build target. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#51797) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/7dc399e01f98..0970776d543a 2024-03-30 [email protected] Roll vulkan-deps from b203847466b0 to 778a83fe011e (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#51799) https://dart.googlesource.com/sdk.git/+log/572de60e008a..b735974580e7 2024-03-30 [email protected] Version 3.5.0-5.0.dev 2024-03-30 [email protected] Version 3.5.0-4.0.dev If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dart-sdk-flutter-engine Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter Engine: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…... (flutter#51801) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-linux-sdk-flutter-engine Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
https://skia.googlesource.com/skia.git/+log/0970776d543a..c61843470d89 2024-03-31 [email protected] Roll SK Tool from 341432c665a4 to df0949e75440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-flutter-autoroll Please CC [email protected],[email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Closes flutter/flutter#141641, yay we done! --------- Co-authored-by: Zachary Anderson <[email protected]>
Part 1 of flutter/flutter#145263 This PR updates the names of builds outside of `local_engine.json` to be prefixed with the string `ci/` (or `ci\` on Windows). For better or worse, the "name" field of a build is used to construct a path used as the source directory of a copy operation (I think the CAS archive step?). Because of that, changing the name of a build also requires updating the build output directory of the ninja build. This PR also adds tests to make sure the naming of these builds remains consistent.
…er with ArrayDeques (flutter#51494) Inspired by flutter#50767. [As their documentation notes](https://docs.oracle.com/javase/8/docs/api/java/util/ArrayDeque.html), `ArrayDeque`s are generally faster than LinkedList when used as a queue. Fixes flutter/flutter#143721 [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
- Destroy ImageReaders on memory trim. - Unset the VirtualDisplay's surface on memory trim. - On resume, recreate ImageReaders. - On resume, do a dumb little dance and then set the VirtualDisplay's surface Fixes: flutter/flutter#146499 Fixes: flutter/flutter#144219 Internal bug: b/335646931 Android Fix: https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/27015418 Android 15 will include the fix. Unclear if Android 14 will be patched.
|
@itsjustkevin Should this CP be against |
Yes, this should be based against |
reidbaker
changed the base branch from
flutter-3.22-candidate.1
to
flutter-3.22-candidate.0
github-actions
bot
added
platform-ios
platform-web
|
Dang I branched off of .1 because that was the base branch the last few cherry picks I was involved in. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [CP] Beta/3.22 Platform view android 14 workaround flutter#147644
Includes #51494 to avoid merge conflicts and have a clean merge.
Pre-launch Checklist
///).