Add Semantics Property `linkUrl` #53507

mdebbar · 2024-06-21T20:36:00Z

The new property allows the user to specify a URI for their semantics link node. It's plumbed through for both web and non-web engines, but it's only used in the web engine currently. It sets the href of the anchor element associated with semantics node.

This is going to unlock better semantics support in the Link widget on web (PR).

Framework counterpart: flutter/flutter#150639

Part of flutter/flutter#150263

yjbanov · 2024-06-21T22:04:01Z

lib/web_ui/lib/src/engine/semantics/semantics.dart

@@ -337,6 +338,9 @@ class SemanticsNodeUpdate {

  /// See [ui.SemanticsUpdateBuilder.updateNode].
  final int headingLevel;
+
+  /// See [ui.SemanticsUpdateBuilder.updateNode].
+  final String? linkUri;


linkUri is non-nullable in the updateNode API. Does it need to be nullable here?

This mirrors the code for the nullable tooltip field. I think it is non-nullable in the updateNode API to make it easier for the C++ side to handle.

yjbanov · 2024-06-21T22:05:00Z

lib/web_ui/lib/src/engine/semantics/link.dart

    element.style.display = 'block';
+    if (semanticsObject.hasLinkUri) {


Can the link change? If yes, this code should probably go into an override of the update method and it should also check for isLinkUriDirty.

Good catch!

yjbanov · 2024-06-21T22:14:45Z

lib/ui/fixtures/ui_test.dart

@@ -233,6 +233,7 @@ void sendSemanticsUpdate() {
    childrenInHitTestOrder: childrenInHitTestOrder,
    additionalActions: additionalActions,
    headingLevel: 0,
+    linkUri: '',


I think "URL" is more accurate here than "URI". The <a> tag and the Link widget only work with URIs that are also fetchable over the network via the same URI. Using arbitrary URIs as abstract identifiers without being able to fetch them is not something that's supported by this property, AFAICT. Unless there's something on the mobile side that extends beyond that?

yjbanov

auto-submit · 2024-07-03T18:58:53Z

auto label is removed for flutter/engine/53507, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

Prepares for flutter/engine#53507 by adding a missing parameter to the `updateNode` test method. Part of #150263

…151293) flutter/engine@4190543...8e2d05f 2024-07-04 [email protected] [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 [email protected] Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 [email protected] [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 [email protected] Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 [email protected] [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 [email protected] [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 [email protected] Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 [email protected] Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 [email protected] [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 [email protected] [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 [email protected] fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 [email protected] Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 [email protected] Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…151261) Prepares for flutter/engine#53507 by adding a missing parameter to the `updateNode` test method. Part of flutter#150263

…lutter#151293) flutter/engine@4190543...8e2d05f 2024-07-04 [email protected] [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 [email protected] Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 [email protected] [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 [email protected] Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 [email protected] [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 [email protected] [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 [email protected] Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 [email protected] Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 [email protected] [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 [email protected] [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 [email protected] fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 [email protected] Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 [email protected] Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…151261) Prepares for flutter/engine#53507 by adding a missing parameter to the `updateNode` test method. Part of flutter#150263

…lutter#151293) flutter/engine@4190543...8e2d05f 2024-07-04 [email protected] [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 [email protected] Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 [email protected] [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 [email protected] Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 [email protected] [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 [email protected] [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 [email protected] Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 [email protected] Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 [email protected] [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 [email protected] [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 [email protected] fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 [email protected] Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 [email protected] Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

The new property allows the user to specify a URI for their semantics link node. On the web, it sets the `href` of the anchor element associated with semantics node. This is going to unlock better semantics support in the Link widget on web ([PR](flutter/packages#6711)). Engine counterpart: flutter/engine#53507 Fixes #150263

Add Semantics Property linkUri

73dded3

mdebbar requested review from yjbanov and chunhtai June 21, 2024 20:36

github-actions bot added the platform-web Code specifically for the web engine label Jun 21, 2024

mdebbar mentioned this pull request Jun 21, 2024

Add Semantics Property linkUrl flutter/flutter#150639

Merged

yjbanov reviewed Jun 21, 2024

View reviewed changes

mdebbar and others added 3 commits June 25, 2024 14:45

update href

bbbb01f

Merge branch 'main' into link_uri

9b4ef86

linkUri -> linkUrl plus responding to other review comments

6262539

harryterkelsen changed the title ~~Add Semantics Property linkUri~~ Add Semantics Property linkUrl Jul 3, 2024

Merge branch 'main' into link_uri

d2be434

harryterkelsen requested review from yjbanov and harryterkelsen July 3, 2024 18:09

yjbanov approved these changes Jul 3, 2024

View reviewed changes

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

harryterkelsen mentioned this pull request Jul 3, 2024

Prepares semantics_update_test for upcoming link URL change flutter/flutter#151261

Merged

9 tasks

auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jul 3, 2024

Prepares semantics_update_test for upcoming link URL change (#151261)

8e44e94

Prepares for flutter/engine#53507 by adding a missing parameter to the `updateNode` test method. Part of #150263

Merge branch 'main' into link_uri

c2f954c

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot merged commit 388547a into flutter:main Jul 3, 2024
33 checks passed

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 388547ac4ba8 (10 revisions) flutter/flutter#151278

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

388547ac4 Add Semantics Property linkUrl (flutter/engine#53507)

b5d7ced

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 6db26bc1fbba (11 revisions) flutter/flutter#151285

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

388547ac4 Add Semantics Property linkUrl (flutter/engine#53507)

7e09dbb

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to aaf179cb1cc9 (12 revisions) flutter/flutter#151288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

388547ac4 Add Semantics Property linkUrl (flutter/engine#53507)

2b1e95a

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

388547ac4 Add Semantics Property linkUrl (flutter/engine#53507)

f0bb09d

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151293

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

388547ac4 Add Semantics Property linkUrl (flutter/engine#53507)

f45e992

kevmoo mentioned this pull request Jul 9, 2024

[web] Set the correct href on semantic links #52720

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add Semantics Property `linkUrl` #53507

Add Semantics Property `linkUrl` #53507

Uh oh!

mdebbar commented Jun 21, 2024 •

edited

Loading

Uh oh!

yjbanov Jun 21, 2024

Uh oh!

harryterkelsen Jul 3, 2024

Uh oh!

yjbanov Jun 21, 2024

Uh oh!

mdebbar Jun 24, 2024

Uh oh!

harryterkelsen Jul 3, 2024

Uh oh!

yjbanov Jun 21, 2024

Uh oh!

harryterkelsen Jul 3, 2024

Uh oh!

yjbanov left a comment

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

		element.style.display = 'block';
		if (semanticsObject.hasLinkUri) {

Add Semantics Property linkUrl #53507

Add Semantics Property linkUrl #53507

Uh oh!

Conversation

mdebbar commented Jun 21, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yjbanov Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

yjbanov Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

mdebbar Jun 24, 2024

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

yjbanov Jun 21, 2024

Choose a reason for hiding this comment

Uh oh!

harryterkelsen Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

yjbanov left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Add Semantics Property `linkUrl` #53507

Add Semantics Property `linkUrl` #53507

mdebbar commented Jun 21, 2024 •

edited

Loading