Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. #53587

matanlurey · 2024-06-26T17:54:20Z

... as part of the buildmoot effort.

I'll rebase after @gmackall's definitely-will-work-this-time bump of the dependencies.

…party.

gmackall · 2024-06-26T18:00:33Z

Can I ask why we have both a .../third_party and a /third_party directory

Also

@gmackall's definitely-will-work-this-time bump of the dependencies.

It's different this time, I promise 🙏 (probably)

matanlurey · 2024-06-26T18:03:22Z

Can I ask why we have both a .../third_party and a /third_party directory

Why in this PR, or why in general?

In general because of how https://github.com/flutter/buildroot, an ancient fork from Chromium, works.

gmackall · 2024-06-26T18:05:44Z

Was asking in general, thanks!

matanlurey · 2024-06-26T18:06:53Z

Yeah it's basically Egyptian hieroglyphics at this point. Hopefully we'll have the ../third_party deleted by EOQ3.

…mbedding-deps

matanlurey · 2024-06-29T00:07:34Z

Rebased to HEAD @gmackall!

gmackall

LGTM! Thanks for your patience

reidbaker · 2024-07-02T18:17:28Z

ci/licenses_golden/tool_signature

@@ -1,2 +1,2 @@
-Signature: 2670e7ab781a8bc009ac069d3b7d9cb5


non blocking where does this hash come from?

No idea, CI tells me about it

reidbaker · 2024-07-02T18:18:16Z

tools/licenses/lib/paths.dart

@@ -220,7 +221,6 @@ final Set<String> skippedPaths = <String>{
  r'fuchsia/sdk/mac/NOTICE.fuchsia',
  r'fuchsia/sdk/mac/tools',
  r'out', // output of build
-  r'third_party/android_embedding_dependencies', // Not shipped. Used only for the build-time classpath, and for the in-tree testing framework for Android


Why could this be removed?

as opposed to relocated

auto-submit · 2024-07-03T17:51:59Z

auto label is removed for flutter/engine/53587, due to - The status or check suite Linux linux_license has failed. Please fix the issues identified (or deflake) before re-applying this label.

…mbedding-deps

…lutter/third_party`. (flutter/engine#53587)

…151293) flutter/engine@4190543...8e2d05f 2024-07-04 [email protected] [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 [email protected] Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 [email protected] [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 [email protected] Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 [email protected] [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 [email protected] [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 [email protected] Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 [email protected] Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 [email protected] [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 [email protected] [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 [email protected] fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 [email protected] Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 [email protected] Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…lutter#151293) flutter/engine@4190543...8e2d05f 2024-07-04 [email protected] [Impeller] Re-enable fast blur path for elliptical rrects (flutter/engine#53704) 2024-07-03 [email protected] Roll Skia from 9fd1dc779589 to d5f8dde714e4 (2 revisions) (flutter/engine#53721) 2024-07-03 [email protected] [web] ignore pointer events on plain text spans (flutter/engine#53694) 2024-07-03 [email protected] Add Semantics Property `linkUrl` (flutter/engine#53507) 2024-07-03 [email protected] [Embedder] Document incorrectly named field in FlutterOpenGLFramebuffer. (flutter/engine#53720) 2024-07-03 [email protected] [Impeller] Make storage sizes typed. (flutter/engine#53700) 2024-07-03 [email protected] Convert `run_ios_tests.sh` to `run_ios_tests.dart`. (flutter/engine#53645) 2024-07-03 [email protected] Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. (flutter/engine#53587) 2024-07-03 [email protected] [Impeller] Document how to debug/profile OpenGL ES on macOS. (flutter/engine#53671) 2024-07-03 [email protected] [Flutter Web(HTML)] fix: shader mask is painted incorrectly on shared offscreen canvas (flutter/engine#44998) 2024-07-03 [email protected] fix: mask disappeared when having nested mask filter on Flutter web HTML (flutter/engine#45166) 2024-07-03 [email protected] Roll Skia from 86ee8cc61508 to 9fd1dc779589 (3 revisions) (flutter/engine#53715) 2024-07-03 [email protected] Roll Skia from c14cce59222b to 86ee8cc61508 (1 revision) (flutter/engine#53713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

matanlurey added 2 commits June 26, 2024 10:52

Move //third_party/android_embedding_dependencies to //flutter/third_…

fffbbe7

…party.

++

da169b6

matanlurey requested a review from gmackall June 26, 2024 17:54

github-actions bot added the platform-android label Jun 26, 2024

Merge remote-tracking branch 'upstream/main' into buildmoot-android-e…

516bdf7

…mbedding-deps

matanlurey marked this pull request as ready for review June 29, 2024 00:07

gmackall approved these changes Jun 29, 2024

View reviewed changes

matanlurey added 2 commits July 1, 2024 16:04

++

1cfe31f

++

6309bde

reidbaker approved these changes Jul 2, 2024

View reviewed changes

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

matanlurey added 2 commits July 3, 2024 10:52

Merge remote-tracking branch 'upstream/main' into buildmoot-android-e…

fe4f12d

…mbedding-deps

++

e4e2709

matanlurey added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot merged commit 7f72aeb into flutter:main Jul 3, 2024
33 checks passed

matanlurey deleted the buildmoot-android-embedding-deps branch July 3, 2024 18:58

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 84769c81cd6a (7 revisions) flutter/flutter#151264

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

d222668

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 1af5cef1432c (8 revisions) flutter/flutter#151270

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

10fc47d

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 31fd415056a3 (9 revisions) flutter/flutter#151275

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

0982249

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 388547ac4ba8 (10 revisions) flutter/flutter#151278

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

96ef7f3

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 3, 2024

Roll Flutter Engine from 4190543cb093 to 6db26bc1fbba (11 revisions) flutter/flutter#151285

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 3, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

12035a3

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to aaf179cb1cc9 (12 revisions) flutter/flutter#151288

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

ec87220

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

3930ce3

…lutter/third_party`. (flutter/engine#53587)

engine-flutter-autoroll mentioned this pull request Jul 4, 2024

Roll Flutter Engine from 4190543cb093 to 8e2d05fa95d7 (13 revisions) flutter/flutter#151293

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 4, 2024

7f72aebeb Move //third_party/android_embedding_dependencies to `//f…

9e88e8d

…lutter/third_party`. (flutter/engine#53587)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. #53587

Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. #53587

Uh oh!

matanlurey commented Jun 26, 2024

Uh oh!

gmackall commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 26, 2024

Uh oh!

gmackall commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 29, 2024 •

edited

Loading

Uh oh!

gmackall left a comment

Uh oh!

reidbaker Jul 2, 2024

Uh oh!

matanlurey Jul 3, 2024

Uh oh!

reidbaker Jul 2, 2024

Uh oh!

reidbaker Jul 2, 2024

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Move //third_party/android_embedding_dependencies to //flutter/third_party. #53587

Move //third_party/android_embedding_dependencies to //flutter/third_party. #53587

Uh oh!

Conversation

matanlurey commented Jun 26, 2024

Uh oh!

gmackall commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 26, 2024

Uh oh!

gmackall commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 26, 2024

Uh oh!

matanlurey commented Jun 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

matanlurey Jul 3, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Jul 2, 2024

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

Uh oh!

Uh oh!

Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. #53587

Move `//third_party/android_embedding_dependencies` to `//flutter/third_party`. #53587

matanlurey commented Jun 29, 2024 •

edited

Loading