This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[engine] reland: always post tasks for platform channel responses. #55006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
jason-simmons
approved these changes
Sep 6, 2024
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…154764) flutter/engine@419fb8c...b9f9015 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
reason for revert: still failling mac module test |
jonahwilliams
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
Sep 7, 2024
…onses. (#55006)" (#55022) Reverts: #55006 Initiated by: jonahwilliams Reason for reverting: still failling mac module test Original PR Author: jonahwilliams Reviewed By: {jason-simmons} This change reverts the following previous change: Reland of #54975 Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
auto-submit bot
added a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…visions) (#154764)" (#154765) Reverts: #154764 Initiated by: jonahwilliams Reason for reverting: failing post submit on mac module test. Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@419fb8c...b9f9015 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Sep 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Sep 7, 2024
…154769) flutter/engine@419fb8c...7bf1169 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] reland: always post tasks for platform channel responses. (#55006)" (flutter/engine#55022) 2024-09-07 [email protected] Turn off software rendering in iOS scenario golden tests (flutter/engine#55016) 2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018) 2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006) 2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014) 2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996) 2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917) 2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982) 2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013) 2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913) 2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008) 2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974) 2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001) 2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 8, 2024
…t navigation on start. (#55027) This is a re-land of #55006, except that we special case the navigation channel to immediately dispatch its message if the isolate is not yet running. This preserves the existing behavior relied upon by several iOS add2app tests, as well as the still used embedder v1 - and potentially undicovered future embedders.
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…lutter#55006) Reland of flutter#54975 Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…onses. (flutter#55006)" (flutter#55022) Reverts: flutter#55006 Initiated by: jonahwilliams Reason for reverting: still failling mac module test Original PR Author: jonahwilliams Reviewed By: {jason-simmons} This change reverts the following previous change: Reland of flutter#54975 Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
jesswrd
pushed a commit
to jesswrd/engine
that referenced
this pull request
Sep 11, 2024
…t navigation on start. (flutter#55027) This is a re-land of flutter#55006, except that we special case the navigation channel to immediately dispatch its message if the isolate is not yet running. This preserves the existing behavior relied upon by several iOS add2app tests, as well as the still used embedder v1 - and potentially undicovered future embedders.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #54975
Fixes the initial route behavior for iOS. Previously the initial route setting would always be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.