Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reverts "[engine] reland: always post tasks for platform channel responses. (#55006)" #55022

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

auto-submit[bot]
Copy link
Contributor

@auto-submit auto-submit bot commented Sep 7, 2024

Reverts: #55006

Initiated by: jonahwilliams

Reason for reverting: still failling mac module test

Original PR Author: jonahwilliams

Reviewed By: {jason-simmons}

This change reverts the following previous change:
Reland of #54975

Fixes the initial route behavior for iOS. Previously the initial route setting would always be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.

@auto-submit auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Sep 7, 2024
@auto-submit auto-submit bot merged commit 7bf1169 into main Sep 7, 2024
6 checks passed
@auto-submit auto-submit bot deleted the revert_6dbd735740df66927187422c89d379aab9db4229 branch September 7, 2024 02:56
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 7, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Sep 7, 2024
…154769)

flutter/engine@419fb8c...7bf1169

2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[engine] reland: always post tasks for platform channel responses. (#55006)" (flutter/engine#55022)
2024-09-07 [email protected] Turn off software rendering in iOS scenario golden tests (flutter/engine#55016)
2024-09-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[skwasm] use temporary RawPaint objects (#54917)" (flutter/engine#55018)
2024-09-06 [email protected] [engine] reland: always post tasks for platform channel responses. (flutter/engine#55006)
2024-09-06 [email protected] Roll Skia from 4786936b4c0c to 06cd203d0607 (2 revisions) (flutter/engine#55014)
2024-09-06 [email protected] [multiple] Avoid new `unreachable_switch_default` warning. (flutter/engine#54996)
2024-09-06 [email protected] [skwasm] use temporary RawPaint objects (flutter/engine#54917)
2024-09-06 [email protected] [DisplayList] use DlScalar, DlPoint, DlRect exclusively in DlOpReceiver methods (flutter/engine#54982)
2024-09-06 [email protected] Roll Skia from f38ea0134dba to 4786936b4c0c (4 revisions) (flutter/engine#55013)
2024-09-06 [email protected] [Impeller] opt into exp canvas. (flutter/engine#54913)
2024-09-06 [email protected] Roll Skia from 8f62a6a4a299 to f38ea0134dba (4 revisions) (flutter/engine#55008)
2024-09-06 [email protected] [impeller] fake image for fake tests. (flutter/engine#54974)
2024-09-06 [email protected] Roll Skia from 6ad117bd2efe to 8f62a6a4a299 (1 revision) (flutter/engine#55001)
2024-09-06 [email protected] Change "there own" to "their own" in Flutter-GPU docs (flutter/engine#54921)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
jesswrd pushed a commit to jesswrd/engine that referenced this pull request Sep 11, 2024
…onses. (flutter#55006)" (flutter#55022)

Reverts: flutter#55006
Initiated by: jonahwilliams
Reason for reverting: still failling mac module test
Original PR Author: jonahwilliams

Reviewed By: {jason-simmons}

This change reverts the following previous change:
Reland of flutter#54975

Fixes the initial route behavior for iOS. Previously the initial route setting would _always_ be posted as a task, which after merging the threads would fire after isolate creation, thus it would not actually update the initial route setting. Fixed Engine constructor so that it reads the initial route from the settings.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform-ios revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants