Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55402

harryterkelsen · 2024-09-24T20:06:27Z

This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis.

Fixes flutter/flutter#149863

On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps).

This is a reland of #54878 with a fix for scenes with pictures that are eventually entirely clipped out.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
I listed at least one issue that this PR fixes in the description above.
I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
I updated/added relevant documentation (doc comments with ///).
I signed the CLA.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…plitting…" This reverts commit 559f2ff.

yjbanov

… splitting pictures" (flutter/engine#55402)

…155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (#55418)" (flutter/engine#55450) 2024-09-25 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 [email protected] Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 [email protected] [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 [email protected] Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 [email protected] [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 [email protected] Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 [email protected] Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 [email protected] Fixes blend + color filter (flutter/engine#55411) 2024-09-25 [email protected] Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 [email protected] Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 [email protected] [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 [email protected] [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 [email protected] Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 [email protected] adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 [email protected] Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 [email protected] Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

chingjun · 2024-09-26T06:15:20Z

Reason for revert: caused internal tests to fail.

See b/369740500 for more details.

…plitting pictures" (#55402)" This reverts commit 7461499.

…splitting pictures" (#55402)" (#55456) Reverts: #55402 Initiated by: chingjun Reason for reverting: caused internal tests to fail. See b/369740500 for more details. Original PR Author: harryterkelsen Reviewed By: {yjbanov} This change reverts the following previous change: This enhances the overlay optimization by delaying combining pictures to get tighter bounds for the pictures that make up the scene, enabling more sophisticated optimization since we can determine if they intersect with platform views on a per-picture basis. Fixes flutter/flutter#149863 On a Macbook in Chrome in an example app with an infinite scrolling grid of platform views, this brings the ratio of dropped frames from 93% to 55% (roughly 4 fps to 30 fps). This is a reland of #54878 with a fix for scenes with pictures that are eventually entirely clipped out. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style

…lutter#155733) flutter/engine@d6d5fdb...d4850c1 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter#55444)" (flutter/engine#55454) 2024-09-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter#55418)" (flutter/engine#55450) 2024-09-25 [email protected] Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (flutter/engine#55402) 2024-09-25 [email protected] Move lint suppression from `baseline.xml` to `@SuppressLint`. (flutter/engine#55447) 2024-09-25 [email protected] [engine] set platform thread name to ui. (flutter/engine#55362) 2024-09-25 [email protected] Roll Dart SDK from c2728b947e46 to 016368ee313d (1 revision) (flutter/engine#55444) 2024-09-25 [email protected] [Impeller] actually fix external texture for GLES. (flutter/engine#55414) 2024-09-25 [email protected] Roll Skia from e623a37de332 to 9f3b32b7b772 (2 revisions) (flutter/engine#55443) 2024-09-25 [email protected] Remove usages of WindowManager's getDefaultDisplay (flutter/engine#55002) 2024-09-25 [email protected] Fixes blend + color filter (flutter/engine#55411) 2024-09-25 [email protected] Add a boolean that exposes rotation/crop metadata capability. (flutter/engine#55434) 2024-09-25 [email protected] Roll Skia from 9af762100cf1 to e623a37de332 (1 revision) (flutter/engine#55439) 2024-09-25 [email protected] [scenario_app] delete get bitmap activity. (flutter/engine#55436) 2024-09-25 [email protected] [Flutter GPU] Use vm.Vector4 for clear color instead of ui.Color. (flutter/engine#55416) 2024-09-25 [email protected] Roll Dart SDK from dd73afd20be5 to c2728b947e46 (1 revision) (flutter/engine#55437) 2024-09-25 [email protected] adds more tasks to the engine workspace (flutter/engine#55435) 2024-09-25 [email protected] Roll Skia from 79e652aad7a9 to 9af762100cf1 (2 revisions) (flutter/engine#55433) 2024-09-25 [email protected] Add `SurfaceProducer#onSurfaceAvailable`, deprecate `onSurfaceCreated`. (flutter/engine#55418) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Revert "Revert "[canvaskit] Further improve overlay optimization by s…

d0cca5f

…plitting…" This reverts commit 559f2ff.

github-actions bot added the platform-web Code specifically for the web engine label Sep 24, 2024

add test for clipped out picture

91d631d

harryterkelsen requested review from eyebrowsoffire and yjbanov September 25, 2024 20:04

yjbanov approved these changes Sep 25, 2024

View reviewed changes

fix bug when picture is clipped out then comes back in

84d7489

harryterkelsen mentioned this pull request Sep 25, 2024

[html] HTML renderer fails on test with addRetained with clip flutter/flutter#155717

Closed

harryterkelsen added 3 commits September 25, 2024 15:08

skip clip-out-clip-in test on HTML since it crashes

8bb9543

fix too many pops in test

dfbaf5a

remove commented line

ba6618b

harryterkelsen added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 25, 2024

auto-submit bot merged commit 7461499 into main Sep 25, 2024
30 checks passed

auto-submit bot deleted the revert-55401-revert-54878-canvaskit-overlay-split-pictures branch September 25, 2024 23:47

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 746149965de9 (16 revisions) flutter/flutter#155729

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

746149965 Reland "[canvaskit] Further improve overlay optimization by…

151f624

… splitting pictures" (flutter/engine#55402)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 7af5b384314d (17 revisions) flutter/flutter#155730

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

746149965 Reland "[canvaskit] Further improve overlay optimization by…

379aa83

… splitting pictures" (flutter/engine#55402)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to 7af5b384314d (17 revisions) flutter/flutter#155731

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

746149965 Reland "[canvaskit] Further improve overlay optimization by…

b07df2a

… splitting pictures" (flutter/engine#55402)

engine-flutter-autoroll mentioned this pull request Sep 26, 2024

Roll Flutter Engine from d6d5fdba6ae1 to d4850c1ae648 (18 revisions) flutter/flutter#155733

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 26, 2024

746149965 Reland "[canvaskit] Further improve overlay optimization by…

5440e5b

… splitting pictures" (flutter/engine#55402)

chingjun added the revert Label used to revert changes in a closed and merged pull request. label Sep 26, 2024

auto-submit bot pushed a commit that referenced this pull request Sep 26, 2024

Revert "Reland "[canvaskit] Further improve overlay optimization by s…

8d69d3c

…plitting pictures" (#55402)" This reverts commit 7461499.

auto-submit bot mentioned this pull request Sep 26, 2024

Reverts "Reland "[canvaskit] Further improve overlay optimization by splitting pictures" (#55402)" #55456

Merged

8 tasks

auto-submit bot removed the revert Label used to revert changes in a closed and merged pull request. label Sep 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55402

Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55402

harryterkelsen commented Sep 24, 2024 •

edited

Loading

yjbanov left a comment

chingjun commented Sep 26, 2024

Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55402

Reland "[canvaskit] Further improve overlay optimization by splitting pictures" #55402

Conversation

harryterkelsen commented Sep 24, 2024 • edited Loading

Pre-launch Checklist

yjbanov left a comment

Choose a reason for hiding this comment

chingjun commented Sep 26, 2024

harryterkelsen commented Sep 24, 2024 •

edited

Loading